From owner-freebsd-threads@FreeBSD.ORG Fri Nov 27 05:15:06 2009 Return-Path: Delivered-To: threads@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DED3A1065696; Fri, 27 Nov 2009 05:15:06 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 7D11E8FC16; Fri, 27 Nov 2009 05:15:06 +0000 (UTC) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id nAR5HE2s058061; Fri, 27 Nov 2009 00:17:14 -0500 (EST) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: threads@FreeBSD.org Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-2jmAe98E+VyR3nbzFxAH" Organization: FreeBSD, Inc. Date: Fri, 27 Nov 2009 00:15:18 -0500 Message-Id: <1259298918.1608.19.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on creme-brulee.marcuscom.com Cc: kib Subject: [PATCH] Add missing pthread_condattr_{init,destroy} stubs to libc X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 05:15:07 -0000 --=-2jmAe98E+VyR3nbzFxAH Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I would like permission to commit this patch which adds missing pthread_condattr_{init,destroy} symbols to libc. I think I did the symbol addition correctly (and it seems to work). Without this, the weak symbols added in the libpthread-stubs port conflict with those in libthr, and applications with use these symbols can crash. I have temporarily hacked libpthread-stubs to fix this, but I really feel these stubs should be added to libc. I've also copied kib as he has been kind enough to review my work in the past. Thanks. http://www.marcuscom.com/downloads/stubs.diff Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-2jmAe98E+VyR3nbzFxAH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEABECAAYFAksPYGQACgkQb2iPiv4Uz4cFIQCgk/wyBJjwg0i4wYSRjXzQz+kc 9lUAnj/NOMb5yzRlaYqG2FTilaKMjInw =EQpO -----END PGP SIGNATURE----- --=-2jmAe98E+VyR3nbzFxAH--