From owner-dev-commits-src-all@freebsd.org Mon Oct 4 08:48:10 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A00767A0C9; Mon, 4 Oct 2021 08:48:10 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HNDrV0ys1z3tg5; Mon, 4 Oct 2021 08:48:10 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-wr1-f53.google.com with SMTP id u18so29421492wrg.5; Mon, 04 Oct 2021 01:48:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ACTCrNmOCq4OAUif+f58vHyqAoPit73czFSS2fbaBcc=; b=I4b9ujbH0LGxuPmlwORDPP2vmVTHzoGBtdeqWQHa3f7cds7Crl5faWhRyBQo69+n7O zJVrb0luvfXq1EFOoVWxW41rWVbmRRJEt004nJnADvAIGb49WTTaNyNuQ7x1Hu7RiMmS /eM28kGl52TnYV5NgcpnrtBGshRfY8AiX0U2xVbBk8ur56GPDrWqlgjzHzPBFQ/iOr3C EH5IG0o6Vho3vV5LOUTlMDdi+O89cdIQwBiL4ASE6p2wVoO7PsaoDDIHuw+VdI84xuTU JAaBc2mxefGuEnwyt3ybVrVJqkFsAKjo0VYgCvw+i3ZoWSiL38O84U6AN2lM6m8ORBjU BE7A== X-Gm-Message-State: AOAM5315ygwyVO/cQGew+hqOXKGiD6EN7H/EoljXh4lEMBEjnfHu8D8K 3gJ3dt6eOTi0YsJpy9b8eDAX4eFeJgs= X-Google-Smtp-Source: ABdhPJyfyH9adiSqNLXCbKbkcC6U4m1vBiHbda5xuUyeOgnNx4CDYgvqkhNDEq+0ZRwfxvAojpmsWg== X-Received: by 2002:adf:c6c5:: with SMTP id c5mr294799wrh.46.1633337283139; Mon, 04 Oct 2021 01:48:03 -0700 (PDT) Received: from [192.168.0.15] (ip5f5bd4ef.dynamic.kabel-deutschland.de. [95.91.212.239]) by smtp.gmail.com with ESMTPSA id 20sm16232569wme.46.2021.10.04.01.48.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Oct 2021 01:48:02 -0700 (PDT) To: Hans Petter Selasky , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Christos Margiolis References: <202109221803.18MI3gdA013391@gitrepo.freebsd.org> <3d6a23c3-ad2c-4c5b-849e-1ef12dbf8955@FreeBSD.org> <487fa0f2-d845-438f-a035-8b7ccba4285a@selasky.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: Re: git: 903873ce1560 - main - Implement and use new mixer(3) library for FreeBSD. Message-ID: Date: Mon, 4 Oct 2021 10:48:03 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <487fa0f2-d845-438f-a035-8b7ccba4285a@selasky.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: 4HNDrV0ys1z3tg5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Oct 2021 08:48:10 -0000 Hi Hans, On 03/10/2021 21:08, Hans Petter Selasky wrote: > On 10/3/21 6:03 PM, Mateusz Piotrowski wrote: >> On 22/09/2021 20:03, Hans Petter Selasky wrote: >>> The branch main has been updated by hselasky: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D903873ce15600fc02a0ea4= 2cbf888cff232b411d >>> >>> commit 903873ce15600fc02a0ea42cbf888cff232b411d >>> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Hans Petter Selasky >>> AuthorDate: 2021-09-22 13:42:51 +0000 >>> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Hans Petter Selasky >>> CommitDate: 2021-09-22 17:43:56 +0000 >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0 Implement and use new mixer(3) library for F= reeBSD. >>> =C2=A0=C2=A0=C2=A0=C2=A0 Wiki article: https://wiki.freebsd.org/Summe= rOfCode2021Projects/SoundMixerImprovements >>> =C2=A0=C2=A0=C2=A0=C2=A0 This project was part of Google Summer of Co= de 2021. >> >> This may be a bit late to discuss but the new mixer has a completely d= ifferent >> set of options and command-line arguments. In addition to that, >> the output of the command is different. >> >> Shouldn't we keep supporting the previous way of interacting with mixe= r? >> I know that people are scripting mixer and its output in production >> in order to control soundcards. Are there any good reasons to keep the= new >> mixer(8) as it is now while keeping the old name? Perhaps we could cha= nge >> the name of the new mixer to, e.g., newmixer. Users are going to have = to >> rewrite their scripts for mixer(8) anyway for 14.0. >> > > It depends what level of compatibility you need. > > If you have a script parsing mixer output, then it needs to be binary c= ompatible so to speak. That=20 > means some new features like "mute" won't work. Hmm, I agree that mute and volume controls in the new CLI interface are v= ery consistent. However, in=20 case of the old CLI interface, the mute functionality could also be added= without a problem (at=20 least by looking at the manual pages, the "mute" command could look like = this: "mixer mute vol"). My=20 point is that I feel that the CLI interface should be backwards-compatibl= e in this case. > > Would it help to make a port, like "oldmixer", under "audio" ? That's a good idea. I've committed the "old" mixer to the ports tree:=20 https://cgit.freebsd.org/ports/commit/?id=3De9a0efe4509b8dbdef0b4e4b5b94a= bf0aebd78a9. However, I feel that it is a solution to a problem that could have been a= voided. The mixer=20 improvements should have been introduced in a way that users do not have = to do anything to keep=20 their scripts working. At the moment, it does not really matter if a user= has to install an=20 additional port or patch their scripts. In the end, it's extra work and p= otential bugs. On the other hand, from what I understand so far, mixer(8) needed a redes= ign. Also, usually people=20 don't script mixer(8) too heavily so the changes in the interface are goi= ng to be only a minor=20 annoyance when FreeBSD 14.0 is released. An entry in the release notes an= d the availability of the=20 old mixer in the ports tree should be enough. Best, Mateusz Piotrowski