From owner-freebsd-current@FreeBSD.ORG  Wed Apr 27 02:19:42 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 76E8E16A4CE
	for <freebsd-current@freebsd.org>;
	Wed, 27 Apr 2005 02:19:42 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F20F643D48
	for <freebsd-current@freebsd.org>;
	Wed, 27 Apr 2005 02:19:41 +0000 (GMT)	(envelope-from sam@errno.com)
Received: from [66.127.85.92] ([66.127.85.92])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j3R2JXms072698
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 26 Apr 2005 19:19:35 -0700 (PDT)
	(envelope-from sam@errno.com)
Message-ID: <426EF6BD.6030207@errno.com>
Date: Tue, 26 Apr 2005 19:19:41 -0700
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
User-Agent: Mozilla Thunderbird 1.0 (Macintosh/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Marcel Moolenaar <marcel@xcllnt.net>
References: <200504261143.55195.josemi@redesjm.local>
	<20050426194208.GB7773@ns1.xcllnt.net> <426E9E1C.6020609@errno.com>
	<20050426221922.GD8621@ns1.xcllnt.net>
In-Reply-To: <20050426221922.GD8621@ns1.xcllnt.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-current@freebsd.org
cc: Jose M Rodriguez <josemi@freebsd.jazztel.es>
Subject: Re: rigth crc32 implementation
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2005 02:19:42 -0000

Marcel Moolenaar wrote:
> On Tue, Apr 26, 2005 at 01:01:32PM -0700, Sam Leffler wrote:
> 
>>Note also there is CRC32 code of this sort in WEP and TKIP crypto 
>>modules in the net80211 support.
> 
> 
> Sam,
> 
> Given the seperation of crc32() into crc32_raw() and crc32(), with
> either crc32() only or otherwise both functions inlined, are there
> any obstacles preventing the 802.11 code from using the ones in
> src/sys/libkern?

The wep+tkip usage is integral to the cipher so splitting it out would 
likely slow them and, more importantly, would also require revalidation 
(there are test vectors but they're pretty limited).  These modules are 
self-contained for various reasons so I'm leary of switching.  I'll 
think about adding it under an #ifdef for those that want to save 
2Kbytes (the size of the crc tables).

	Sam