From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 15 18:50:35 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C32916A554 for ; Wed, 15 Sep 2004 18:50:35 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F3B543D62 for ; Wed, 15 Sep 2004 18:50:30 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8FIoUuF063784 for ; Wed, 15 Sep 2004 18:50:30 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8FIoUT4063783; Wed, 15 Sep 2004 18:50:30 GMT (envelope-from gnats) Resent-Date: Wed, 15 Sep 2004 18:50:30 GMT Resent-Message-Id: <200409151850.i8FIoUT4063783@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Antoine Brodin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE34116A4CE for ; Wed, 15 Sep 2004 18:41:57 +0000 (GMT) Received: from massena-4-82-67-196-50.fbx.proxad.net (massena-4-82-67-196-50.fbx.proxad.net [82.67.196.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 280BF43D58 for ; Wed, 15 Sep 2004 18:41:57 +0000 (GMT) (envelope-from antoine@massena-4-82-67-196-50.fbx.proxad.net) Received: from massena-4-82-67-196-50.fbx.proxad.net (localhost.fbx.proxad.net [127.0.0.1])id i8FIg0Lc001212 for ; Wed, 15 Sep 2004 20:42:01 +0200 (CEST) (envelope-from antoine@massena-4-82-67-196-50.fbx.proxad.net) Received: (from antoine@localhost)i8FIftfr001211; Wed, 15 Sep 2004 20:41:55 +0200 (CEST) (envelope-from antoine) Message-Id: <200409151841.i8FIftfr001211@massena-4-82-67-196-50.fbx.proxad.net> Date: Wed, 15 Sep 2004 20:41:55 +0200 (CEST) From: Antoine Brodin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71773: [patch] genericize.pl -c misses some comments X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Antoine Brodin List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2004 18:50:36 -0000 >Number: 71773 >Category: bin >Synopsis: [patch] genericize.pl -c misses some comments >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 15 18:50:29 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Antoine Brodin >Release: FreeBSD 6.0-CURRENT i386 >Organization: none >Environment: System: FreeBSD massena-4-82-67-196-50.fbx.proxad.net 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Mon Sep 13 17:05:28 CEST 2004 root@massena-4-82-67-196-50.fbx.proxad.net:/usr/obj/usr/src/sys/BARTON i386 >Description: The genericize.pl script in src/tools/tools/genericize misses some comments when invoked with -c option. >How-To-Repeat: Use genericize.pl -c on a GENERIC i386 config It misses two lines : # output. Adds ~128k to driver. and # output. Adds ~215k to driver. >Fix: Apply this patch : --- genericize.patch begins here --- Index: genericize.pl =================================================================== RCS file: /home/ncvs/src/tools/tools/genericize/genericize.pl,v retrieving revision 1.2 diff -u -r1.2 genericize.pl --- genericize.pl 29 Aug 2004 19:45:50 -0000 1.2 +++ genericize.pl 15 Sep 2004 17:50:00 -0000 @@ -66,7 +66,7 @@ while () { my $line = $_; chomp(); - if ($opts{'c'} && m/^\#/) { + if ($opts{'c'} && m/^\s*\#/) { if ($blank) { print "\n"; $blank = 0; --- genericize.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: