Date: Wed, 15 Sep 2004 20:41:55 +0200 (CEST) From: Antoine Brodin <antoine.brodin@laposte.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71773: [patch] genericize.pl -c misses some comments Message-ID: <200409151841.i8FIftfr001211@massena-4-82-67-196-50.fbx.proxad.net> Resent-Message-ID: <200409151850.i8FIoUT4063783@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71773
>Category: bin
>Synopsis: [patch] genericize.pl -c misses some comments
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Sep 15 18:50:29 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Antoine Brodin
>Release: FreeBSD 6.0-CURRENT i386
>Organization:
none
>Environment:
System: FreeBSD massena-4-82-67-196-50.fbx.proxad.net 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Mon Sep 13 17:05:28 CEST 2004 root@massena-4-82-67-196-50.fbx.proxad.net:/usr/obj/usr/src/sys/BARTON i386
>Description:
The genericize.pl script in src/tools/tools/genericize misses
some comments when invoked with -c option.
>How-To-Repeat:
Use genericize.pl -c on a GENERIC i386 config
It misses two lines :
# output. Adds ~128k to driver.
and
# output. Adds ~215k to driver.
>Fix:
Apply this patch :
--- genericize.patch begins here ---
Index: genericize.pl
===================================================================
RCS file: /home/ncvs/src/tools/tools/genericize/genericize.pl,v
retrieving revision 1.2
diff -u -r1.2 genericize.pl
--- genericize.pl 29 Aug 2004 19:45:50 -0000 1.2
+++ genericize.pl 15 Sep 2004 17:50:00 -0000
@@ -66,7 +66,7 @@
while (<GENERIC>) {
my $line = $_;
chomp();
- if ($opts{'c'} && m/^\#/) {
+ if ($opts{'c'} && m/^\s*\#/) {
if ($blank) {
print "\n";
$blank = 0;
--- genericize.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409151841.i8FIftfr001211>