Date: Fri, 27 Jul 2018 10:23:17 -0600 From: Warner Losh <imp@bsdimp.com> To: Takanori Watanabe <takawata@init-main.com> Cc: freebsd-acpi@freebsd.org Subject: Re: Please review: D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match Message-ID: <CANCZdfr1DAiS5eF0-cLZtKiMRnVzpgpUyjg1xBwW1a_yzTYbyw@mail.gmail.com> In-Reply-To: <201807271523.w6RFNUWG077685@sana.init-main.com> References: <201807271523.w6RFNUWG077685@sana.init-main.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 27, 2018 at 9:23 AM, Takanori Watanabe <takawata@init-main.com> wrote: > Please review following patch. > The main purpose of this patch is exclude _CID match from > acpi_sysresource driver to attach more appropriate driver. > This patch changes KPI so I want to hear from who may concern. > > https://reviews.freebsd.org/D16468 I've looked at it, and I think the KPI change is reasonable (although it may make merging back to 11 a little harder). I have some minor concerns about the code, which I voiced in the review. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr1DAiS5eF0-cLZtKiMRnVzpgpUyjg1xBwW1a_yzTYbyw>