From nobody Thu Mar 26 01:25:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fh5gQ448Nz6X5Bq for ; Thu, 26 Mar 2026 01:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fh5gQ2cBbz3Qst for ; Thu, 26 Mar 2026 01:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774488322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vieKAWh9yfz3OlwSQ+9ktZDbpISSeP8IZA3Ovy4uoF4=; b=Eb4MY4waFcVizf0T+A5/tbLZvM8pnKaoD4lyKPGNNBAQZ2rdQXSIT/HR3jd3yFpGjMgUHo LJFjP4lHmycFej+SrCmabo1Tcqzizx0+F9+dyW7MG6gy2eIvAJkzWCNT8796XwTwNQT+xb M6d4sgoMdBtxdmvhkoUjL7rUhhwwfaiROeAgM4UYbekLlVWPr40VVcmc+cla6Yj7nqoYWe wk76t0vPeDDNm5okLC/gULhLAiZDy8ttC2MkvOow5/FeFFKmbWecnC1T2SoJkQgWtr3O79 FkD9zZ0kg4Q9xHiL3M89PTQF0f9PFu79d2k6/VNLZH3sndANAY42iFALe+vPKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774488322; a=rsa-sha256; cv=none; b=JyjxEDI7NZI9S2PrmUFj5s1DTaMr6cGxveI7XC7RCpczzfSDQbevUDXk1c4SFiNdRm8Xu4 UBNtQLQXndR70GoT+wk3g6+u36GScPQNb+2zddDJ/iIk7SlrxWtxZQA8bCqLuKpUhuiO8N kXim/8A5PhcEe1pOYsjEJiOd9nEvO0yvE92OCEoWxXkKlLsRRhYIumk1xUqDulFGqlCBaJ kqA+XSVsw5JM2Os8KB+NZuS4i9motivdQSGxUuoKs/fKd7qd/5Kq2zYAxS4j03Ninj5on3 4oAaTuKSqPmkgByyDN5+Mz3FyiDYm5fMPH4t4D+zjseWlvjI1YlG8tFS0xHdnA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774488322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vieKAWh9yfz3OlwSQ+9ktZDbpISSeP8IZA3Ovy4uoF4=; b=SgsLLeNxb7jwW4YO6NqDPq0IpWbef7a9o2+SXtFsYD7XcUgRuZwulxThaBrg8+3kQaEDKd 2kpMKtiWVOu19XP4Pnup84uC+lKVxUV5aB6gFeEVnqMhy+Q1uvYz9QuKSiHRoDq9+lJFNS 63T/8PKM3sTkfAMQykkCX0uI1kHIOzywJywbg3r3lvte8mSucsQc+mLTAEylt8B6lspP1R XHyA8KQbMRNouJJjc6vqDIay2acC7rbXUk4yrLaozMZ0PceI9AuJwO32CfQnumOSQ0J9RP SGY+JzQNeospTW8FCuSuoAmjy1cJTvPVr+IMCQRPBayLQmSyHHfqVLunSZRz3A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fh5gQ2CYwzVkp for ; Thu, 26 Mar 2026 01:25:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47ee6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Mar 2026 01:25:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Michael Tuexen From: Gordon Tetlow Subject: git: 1fddb5435315 - stable/15 - tcp: plug an mbuf leak List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 1fddb5435315ca44c96960b16bdda8338afd15a1 Auto-Submitted: auto-generated Date: Thu, 26 Mar 2026 01:25:22 +0000 Message-Id: <69c48b02.47ee6.519c42bb@gitrepo.freebsd.org> The branch stable/15 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=1fddb5435315ca44c96960b16bdda8338afd15a1 commit 1fddb5435315ca44c96960b16bdda8338afd15a1 Author: Michael Tuexen AuthorDate: 2026-03-25 05:53:56 +0000 Commit: Gordon Tetlow CommitDate: 2026-03-26 01:25:02 +0000 tcp: plug an mbuf leak When a challenge ACK should be sent via tcp_send_challenge_ack(), but the rate limiter suppresses the sending, free the mbuf chain. The caller of tcp_send_challenge_ack() expects this similar to the callers of tcp_respond(). Approved by: so Security: FreeBSD-SA-26:06.tcp Security: CVE-2026-4247 Reviewed by: lstewart Tested by: lstewart Sponsored by: Netflix, Inc. (cherry picked from commit 6b2d6ccad2552e46a5c9c3ba70b2d0ed27c70ca8) --- sys/netinet/tcp_subr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index b6f428b279b3..5e2b1eb1a86d 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -2202,6 +2202,8 @@ tcp_send_challenge_ack(struct tcpcb *tp, struct tcphdr *th, struct mbuf *m) tcp_respond(tp, mtod(m, void *), th, m, tp->rcv_nxt, tp->snd_nxt, TH_ACK); tp->last_ack_sent = tp->rcv_nxt; + } else { + m_freem(m); } }