From owner-freebsd-virtualization@freebsd.org Tue May 5 11:51:05 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E2CF12E331E for ; Tue, 5 May 2020 11:51:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49GdN95lb4z3MH2 for ; Tue, 5 May 2020 11:51:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C55BA2E331D; Tue, 5 May 2020 11:51:05 +0000 (UTC) Delivered-To: virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C52032E331C for ; Tue, 5 May 2020 11:51:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49GdN94sGzz3MH0 for ; Tue, 5 May 2020 11:51:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 88212D771 for ; Tue, 5 May 2020 11:51:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 045Bp5Sb065480 for ; Tue, 5 May 2020 11:51:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 045Bp5Yh065479 for virtualization@FreeBSD.org; Tue, 5 May 2020 11:51:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 246121] [bhyve][PATCH] Append Keyboard Layout specified option for using VNC. Date: Tue, 05 May 2020 11:51:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koinec@yahoo.co.jp X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2020 11:51:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246121 --- Comment #2 from Koine Yuusuke --- Thank you for you interest in the patch. Unfortunately, I understand that the your suggestions are difficult for the following reasons. The virtual PS2 keyboard driver of the bhyve has a table for converting ASC= II code for keys that can be expressed in ASCII characters and Xorg keysym code for keys that cannot be expressed in ASCII characters (example Enter or Esc= ape key,etc) to ScanCode Set2 of the PS2 keyboard. This patch updates this conversion table based on the layout setting file. The /usr/share/vt/keymaps/* file contain the correspondence of ASCII charac= ters or key names (key names is unique to vt/syscons, not Xorg keysym) correspon= ding to the scancode (for vt/syscons) converted from ScanCode Set2 of the PS2 keyboard device. In addition, I confirmed that the conversion algorithm from ScanCode Set2 of the PS2 keyboard to scancode (for vt/syscons) is implemented in /usr/src/sys/dev/atkbdc/atkbd.c, so I think that it is not impossible to use the /usr/share/vt/keymaps/* file as the basis for the keys that can be represented by ASCII characters. (Since it has not been examined in detail, I don't understand whether ScanC= ode Set2 of the PS2 keyboard can actually be converted from scancode (for vt/syscons) to the reverse.) On the other hand, a key that cannot be represented by ASCII characters can= not be supported because the value of Xorg keysym value doesn't exist in /usr/share/vt/keymaps/* file. (For reference, the value of Xorg keysym value is in the /usr/local/include/X11/keysymdef.h) Therefore, even if the key layout conversion information that can be expres= sed in ASCII characters is acquired from /usr/share/vt/keymaps/* file, the key = that cannot be expressed in ASCII characters cannot be acquired from /usr/share/vt/keymaps/* file, and thus I think that a layout configuration = file for each language is required. If you have a good idea to use /usr/share/vt/keymaps/* file, please let me know. (I also don't want to have a layout configuration file for bhyve apart from /usr/share/vt/keymaps/* file. But I did this because I couldn't think of any other simple way...) - Koine Yuusuke (koinec) --=20 You are receiving this mail because: You are the assignee for the bug.=