From owner-svn-src-head@FreeBSD.ORG Fri Jan 20 11:06:07 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B41C1065674; Fri, 20 Jan 2012 11:06:07 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id A4CF48FC0C; Fri, 20 Jan 2012 11:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=V2H1TfaMa2ZpsShGasOgse9LVcSpL+FM3PcJenMGhMk=; b=nxHRAi6WwKPnEeACqawNIOI4qG9mUSzGxBhxk54KiaDvTO0eWjJmZH8sUts/E9iu38Ev2Zj5R7gIqUoIXjtPkD3Vx/2uWKzIm3iM4ipJ6kmf/sdTuY1rk+iDiYaD9C7rN9PW4luPuF6QQlPSvVEKY73T4aIjjyusNd8N0CPHMSKYV0it0u1kATpnH7FStTKcVGX1oopO0Vu2+uzdovHCtNEzGVPf4TjbvnQpr/jHxOzqDN2pU5aAGgIUUC2ur+1GjEiIyZx4WN3LisROpDIJxLKPDYYn9VjX8qAyCnNhOI3PGq/dKXqwfGafP4oELUROKcKwBJAxAQeg44fJcT+hjQ==; Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1RoCIH-0008gj-Dy; Fri, 20 Jan 2012 14:06:05 +0300 Date: Fri, 20 Jan 2012 15:06:02 +0400 From: Eygene Ryabinkin To: Brooks Davis Message-ID: <7dcvawMgnE9O34bJ7H3SrdYasTs@HbohoBmewgxm0atwUoKO7zhAAgw> References: <201201120648.q0C6mBio096662@svn.freebsd.org> <201201120748.28564.jhb@freebsd.org> <201201121438.16674.jhb@freebsd.org> <20120119172759.GC60214@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Uwl7UQhJk99r8jnw" Content-Disposition: inline In-Reply-To: <20120119172759.GC60214@lor.one-eyed-alien.net> Sender: rea@codelabs.ru Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, John Baldwin Subject: Re: svn commit: r230007 - in head: etc etc/rc.d share/man/man8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 11:06:07 -0000 --Uwl7UQhJk99r8jnw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thu, Jan 19, 2012 at 11:27:59AM -0600, Brooks Davis wrote: > On Fri, Jan 13, 2012 at 11:21:48AM +0400, Eygene Ryabinkin wrote: > > The related topic: in the process of grepping for dhclient within > > /etc, I had found that /etc/netstart still wants to invoke it. But it > > will do a lone '/etc/rc.d/dhclient quietstart' and this will never > > be useful in the current state of dhclient: it will refuse to process > > any commands without the interface being specified. And since we > > have the invocation of /etc/rc.d/netif just two lines above, I think > > that it will be good to remove call to dhclient from /etc/netstart. [...] >=20 > Removing it from /etc/netstart is the right thing to do. Will do it today. > Arguably it should be moved to /libexec since it's not an rc.d > script and simply uses the framework because it had similar needs Well, I fear that some user scripts may rely on the dhclient path to be /etc/rc.d/dhclient, so such a change could lead to the POLA violation. So, all pros and cons of such a change should be carefully weighted. What is the gain from moving it to /libexec apart from avoiding pollution of /etc/rc.d by non-rc.d scripts? It is a good thing to have for the clear design, but having dhclient in /etc/rc.d has no effect on the boot process, since it is marked 'nostart' and it allows people to use 'service dhclient restart $if' without hacking the service to still allow to use this command. We can, of course, move it to /libexec/rc.d/ and add this path to the local_startup, but I doubt that this approach will give any real gain, though I can be missing some important points. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --Uwl7UQhJk99r8jnw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EABEIAAYFAk8ZSpoACgkQFq+eroFS7PsM9QD/TlfxrPer4UoXt/WjC1Ez2qUM z4uWjMpRLGzUCJfzzHoA/jdcmHHjORdPq5NPY2/R/AB07/uZEguSbXZFRRbrTDcl =eaQT -----END PGP SIGNATURE----- --Uwl7UQhJk99r8jnw--