From owner-svn-src-all@FreeBSD.ORG Wed May 20 18:42:51 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17CFAF0B; Wed, 20 May 2015 18:42:51 +0000 (UTC) Received: from mail-ie0-x22a.google.com (mail-ie0-x22a.google.com [IPv6:2607:f8b0:4001:c03::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CDA69154F; Wed, 20 May 2015 18:42:50 +0000 (UTC) Received: by iepj10 with SMTP id j10so46178953iep.3; Wed, 20 May 2015 11:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=GIQSN3IHAGAfATcxB736etClHu+LZFm6jXOKO8lHDlI=; b=QawhIcLZEIL0Y0v1Aoa4iC23C21iSpqNMHQqJOL/E4147/GOZMDXoBmfMtjvlaeF8m AVAAHQMtWFRs/ai4IPFILYDV9Kuo8gmEKYhd6lk/S5ODa9p/MmX/0gpjtLlV+PTiW9Ja NAm1eVtDRS5XtunU5ZbxssZCvxUmmuOUoJKWRsgVv8Pl8exM7VZUiHX3YcCmoGdKP+Tp qXzyXt5HZcFJzorjwmFxkWYVaZ7TqZUQyDHtbOiBhp5zmD7BZVlWMRbF4BZLlwsAtLr7 q6iHpdSgltDXBj4S1KrewDu2+y7zpz4GQvfn9y00LSiDsT5f7ebmWrUcaZUVZ7kJh3Ii GA4A== X-Received: by 10.50.61.200 with SMTP id s8mr30209191igr.7.1432147369774; Wed, 20 May 2015 11:42:49 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:d5de:dc48:8df9:aa7e? ([2601:8:ab80:7d6:d5de:dc48:8df9:aa7e]) by mx.google.com with ESMTPSA id if2sm2165939igb.15.2015.05.20.11.42.48 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 May 2015 11:42:48 -0700 (PDT) Subject: Re: svn commit: r283151 - head Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_E41B7878-0AAA-45BC-9B2F-848F47D00D40"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Garrett Cooper In-Reply-To: Date: Wed, 20 May 2015 11:42:45 -0700 Cc: Andriy Gapon , Garrett Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <8F1BC78E-1C33-4E12-84FF-0AA682609907@gmail.com> References: <201505201304.t4KD41Bn063189@svn.freebsd.org> <555CBDE2.6080401@FreeBSD.org> <555CC352.60302@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.1878.6) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 18:42:51 -0000 --Apple-Mail=_E41B7878-0AAA-45BC-9B2F-848F47D00D40 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 On May 20, 2015, at 10:43, Craig Rodrigues wrote: > On Wed, May 20, 2015 at 10:24 AM, Andriy Gapon = wrote: > >> > >> lib/libproc__L: \ > >> - cddl/lib/libctf__L lib/libelf__L lib/librtld_db__L = lib/libutil__L > >> + ${_cddl_lib_libctf} lib/libelf__L lib/librtld_db__L = lib/libutil__L >=20 > Should the above perhaps be ${_cddl_lib_libctf}__L? But such that it = is empty > if _cddl_lib_libctf is unset. Not sure how to express that with the = make > syntax. In shell it'd be ${_cddl_lib_libctf:+${_cddl_lib_libctf}__L}. >=20 >=20 > You can use: >=20 > ${_cddl_lib_libctf:D${_cddl_lib_libctf}__L} >=20 >=20 > If you look at the make(1) man page and look for the section > "Variable modifiers", you can see the documentation for this. Fixed in r283159. Thank you Craig! --Apple-Mail=_E41B7878-0AAA-45BC-9B2F-848F47D00D40 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVXNWmAAoJEMZr5QU6S73eEDEH/3Ia9WtEteT6st0gDY8SE0x/ WFlKsM6J1P5RN8G1ZN/maNe/ksbL/ipivAnBfGMgNZmdSV0bSzZRM2D5urvy6Sh+ 1v8umdNRbRL0ZV+MqiYF4aVFiCVNL4YJm2KB044DOpSghAOhnwLa7+dfeSBoePh4 Pc1nVj1V+DHTIIXv0GMcRxcN+kSlLpgiaFxIFSZViK+UdhOjuqAj+60zKjJgU4/B Hlc6gw+uQ7CmKhvhZKz6b8uZu8sC+Ih5KNQhsPTTjOr5iCXIwuDLdeXOlt8SK0c+ povKaPQrY4Hrb+CltPA1gyuZV7RoV3YAaUj4qWRSWFr86iJ/+3dMnCY1Y/tDy/w= =vhd3 -----END PGP SIGNATURE----- --Apple-Mail=_E41B7878-0AAA-45BC-9B2F-848F47D00D40--