Date: Fri, 09 Jul 2010 15:34:09 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: jmallett@FreeBSD.org Cc: freebsd-mips@FreeBSD.org Subject: Re: Merging 64 bit changes to -HEAD - part 4 Message-ID: <20100709.153409.59640143160064195.imp@bsdimp.com> In-Reply-To: <AANLkTimcCqP2SinyKJUqpT9l0j07AqGCLxMCuCGXc2wA@mail.gmail.com> References: <AANLkTik8fBlxMyZ3AZETF_7DvlSpPsx2hozIWinRy0U0@mail.gmail.com> <20100709.144631.1141490504242621103.imp@bsdimp.com> <AANLkTimcCqP2SinyKJUqpT9l0j07AqGCLxMCuCGXc2wA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <AANLkTimcCqP2SinyKJUqpT9l0j07AqGCLxMCuCGXc2wA@mail.gmail.c=
om>
Juli Mallett <jmallett@FreeBSD.org> writes:
: On Fri, Jul 9, 2010 at 13:46, M. Warner Losh <imp@bsdimp.com> wrote:
: > pmap_map should likely have a comment to the effect:
: > =A0* For memory that's directly mappable, we return the direct map
: > =A0* address. =A0For other addresses, we create a map.
: =
: Doesn't it already?
: =
: * The value passed in '*virt' is a suggested virtual address for
: * the mapping. Architectures which can support a direct-mapped
: * physical to virtual region can return the appropriate address
: * within that region, leaving '*virt' unchanged. Other
: * architectures should map the pages starting at '*virt' and
: * update '*virt' with the first usable address after the mapped
: * region.
That's rather generic, and on some mips we do a mixed-mode here...
: > : mips-ddb-64.patch (from Juli's branch)
: > : Minor fixups for ddb support.
: >
: > Can you explain the casting for all the calls to kbdpeek*?
: =
: Yes. sp is (or should be) a register_t. You can't go from a
: register_t to a pointer on n32. Even if we don't intend to support
: n32 kernels from head, we shouldn't make n32 harder by using the wron=
g
: types without casts :)
True, but can't we redefine these functions such that we don't need
these great big ugly casts? They are written in assembler, after all,
but are specific to mips so the API can change here...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100709.153409.59640143160064195.imp>