From owner-p4-projects@FreeBSD.ORG  Thu Feb  2 02:02:15 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3FAD716A423; Thu,  2 Feb 2006 02:02:15 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 46C1016A420
	for <perforce@freebsd.org>; Thu,  2 Feb 2006 02:02:12 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0C0C643D46
	for <perforce@freebsd.org>; Thu,  2 Feb 2006 02:02:12 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k1222Be8026134
	for <perforce@freebsd.org>; Thu, 2 Feb 2006 02:02:11 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k1222BiZ026131
	for perforce@freebsd.org; Thu, 2 Feb 2006 02:02:11 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Thu, 2 Feb 2006 02:02:11 GMT
Message-Id: <200602020202.k1222BiZ026131@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 90909 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Feb 2006 02:02:16 -0000

http://perforce.freebsd.org/chv.cgi?CH=90909

Change 90909 by rwatson@rwatson_peppercorn on 2006/02/02 02:01:11

	Stub comments about what audit for AUE_SENDFILE will need to
	capture.  This also suppresses the conversion warning for event
	364.
	
	Note: this may require some work, as up until now we've needed only
	to audit a single file descriptor per system call.  sendfile() uses
	two, so will require expanding our in-kernel audit record.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#3 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#3 (text+ko) ====

@@ -439,6 +439,19 @@
 		}
 		break;
 
+	case AUE_SENDFILE:
+		/*
+		 * XXXRW: While sendfile() is effectively a combination of
+		 * read() and write(), it is useful to audit if only because
+		 * it performs IPC/network I/O.  We will need to eventually
+		 * audit the following information to be complete:
+		 *
+		 * - socket information
+		 * - file descriptor information for two file descriptors
+		 * - file information
+		 */
+		break;
+
 	case AUE_ACCT:
 		if (ARG_IS_VALID(kar, ARG_UPATH1)) {
 			UPATH1_VNODE1_TOKENS;