Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 05 Aug 2014 11:09:11 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 188691] [NEW PORT] japanese/latex-jlisting: Enhancement of lstlisting environment for handling Japanese text
Message-ID:  <bug-188691-13-AjoPbhRhSv@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-188691-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-188691-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=188691

--- Comment #2 from John Marino <marino@FreeBSD.org> ---
quick review of shar:

use "NO_BUILD=yes" instead of empty "do-build:" target

don't have post-install target with do-install target, just merge them to
do-install.

change "EXTRACT_SUFX=    .bz2" to "USES+= tar:bz2"

The post-install target looks very suspicious especially since it will not be
run by package (you need a post-install script for that.  But I don't know what
it is supposed to do...

So even if the port is still valid, it needs another iteration and poudriere
test logs (either "testport" or "bulk -t") would be nice too.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-188691-13-AjoPbhRhSv>