From owner-svn-src-all@FreeBSD.ORG Thu Nov 21 06:21:54 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2734C04 for ; Thu, 21 Nov 2013 06:21:54 +0000 (UTC) Received: from mail-vc0-x234.google.com (mail-vc0-x234.google.com [IPv6:2607:f8b0:400c:c03::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8E60E25A2 for ; Thu, 21 Nov 2013 06:21:53 +0000 (UTC) Received: by mail-vc0-f180.google.com with SMTP id if17so3004841vcb.39 for ; Wed, 20 Nov 2013 22:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rbM1fGAeYUBQPVZxbzIE/Ec2gtHCJ8ltHy3Kmagdkbk=; b=mTfCKJ2Cue5Ac+GaKKgG2yuWn9tAdSHMiY6Bs823oae13RRFPhDkl6milgWrm1QO+I RifmS0uVz/akR+/oApEA7Sn0UCIYeu+7pveyZLiU0g98oRKlhP2QYBtF2gPc4RrY86bi zQvJmF6tTpoEKWxmFa8sHz5VcjMYCNWg+scCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=rbM1fGAeYUBQPVZxbzIE/Ec2gtHCJ8ltHy3Kmagdkbk=; b=Lxx+U4hIlyzPad2LtVrbJEx/x3AK+WyzQTmKP/j92zwrGWqL2LYeRDgS1Qzerm0GUw 3vFj4QcM8dCGqYT/CEVbWIf0aYGf+9fwZ6XHOa0Y7RZSR6vunOmlbCDnkqgREvsVmDGT IgRSwl/RfhruLwQTy2xjbZTGnDyKERcBbCr5CR+Gh9DksLcwjBxEL6d0iVzUvJIy3+UO Qrm1dsD+ebiBcmfBk/o+p+bcEYJTX+xMR3m4kLCu+0yuF2F9+lgkmbHuAsPd2Zf3/LKY 5qxl+gYXMyT1NvC7nOacdTQ4SEWz3cymulhlKIYHyvF/AYjQIgzAyhkGDAFGn61kX84f T6IQ== X-Gm-Message-State: ALoCoQl2tiUXiztgzBIyfGRiEkSI7Fb5k4zhP8kLfYlIcwSHdHh8Ty8SFFlrw+P0pE5d6V4Flt18 MIME-Version: 1.0 X-Received: by 10.221.51.206 with SMTP id vj14mr4287733vcb.17.1385014912688; Wed, 20 Nov 2013 22:21:52 -0800 (PST) Received: by 10.220.167.74 with HTTP; Wed, 20 Nov 2013 22:21:52 -0800 (PST) In-Reply-To: <528D274E.5020007@freebsd.org> References: <201311202025.rAKKP0ce054293@svn.freebsd.org> <528D274E.5020007@freebsd.org> Date: Wed, 20 Nov 2013 22:21:52 -0800 Message-ID: Subject: Re: svn commit: r258398 - in stable/10: . include lib lib/libc lib/libc/iconv lib/libc_nonshared sys/sys From: Peter Wemm To: Julian Elischer Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: svn-src-stable@freebsd.org, svn-src-all , "src-committers@freebsd.org" , svn-src-stable-10@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 06:21:55 -0000 On Wed, Nov 20, 2013 at 1:19 PM, Julian Elischer wrote: > On 11/20/13, 12:25 PM, Peter Wemm wrote: > >> +int _iconv_version_compat = 0x0108; /* Magic - not used */ >> + >> >> can you illuminate this a bit more? is it magic, or is it not used? > libiconv has a unique, non-standard, private identifier for its version, 'extern int libiconv_version'. Ours acquired one via search/replace, by accident. In theory, nothing knows of "iconv_version", but in order to be ABI compatible with old 10-alpha/beta snapshots, I left it there via its .symdef alias. "Magic" refers to the old magic number that it had. Not that it does anything special. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV