From owner-svn-src-head@freebsd.org Fri Feb 17 13:22:36 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A527BCE2933; Fri, 17 Feb 2017 13:22:36 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40C6C1852; Fri, 17 Feb 2017 13:22:36 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-lf0-x243.google.com with SMTP id z127so1465831lfa.2; Fri, 17 Feb 2017 05:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=UKTNCKhYFCOsTrcCDlWjlznNi/8g5I0W2skXg67XU2I=; b=GMQofCUBXeeT25RI+EXJGPg8I7qGxAsgYkq3FDu6qENkW+W+fXen4v50FfesOMOOJO zRJhZqw3kblXfAH/FDsTvhk5EkiFXLMbxBaFQGgKD74RN9ez+6HiagxOWbnYjAhVfVdx VISMyVqYHL/aqQU1OaFoLY0bysyfnUZv9ZDs/A2zFyicJjODAbBO+dq12cW8U26RHo7B gy2FfovKKu/3YFAtX8QTsyMmPqLBJxeXOCH2N+LeIWDqBfjeDRg9Pai0OSngLFZg0+Nt RIIowfEqlPcTOhdjhUVE5msn387ZyPrsyW5+Ry6b73VlqbrPBU+d6kYOHDF7AAj6gW4a +ePw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=UKTNCKhYFCOsTrcCDlWjlznNi/8g5I0W2skXg67XU2I=; b=BhnmeYMZAL0hEma++0k/Pwzx4T3mRi/Ns+eb0+vYwZeS8E3B+92yJfdw5bhStQapkW VLUac4jOdJawxXTRKuUJhiMN9AjEEB/SvgaJPrrDl7cjvZIvts8Wsck7vVNZA+fC3Spk OhcCI+hgQfq3pOjSTVVgbU3eb8+r9C/h+0+xP8sLSLtdJ24QCFErqe/lAfdZJYyr0OxE 4IQEPxI0izexXJugQI84QFpJsxd6Q4JDJHtO5qa5ucN8AiZya5+4cPlNeaUQan9IMTbC 0Y4zXOKPU5mxigFRE5RHPBUbfapN+5A3dmt2aEklzvFnsDLISG9b+7DJZBOfpjxMJRxM PxKg== X-Gm-Message-State: AMke39kZhQuS9yXdAd3O1Nlc2BEB2aFg7bEnN0mqX29WupqItZiBoCNzV2TFp2F6tIcqsg== X-Received: by 10.46.84.84 with SMTP id y20mr2060878ljd.111.1487337753011; Fri, 17 Feb 2017 05:22:33 -0800 (PST) Received: from spectre.mavhome.dp.ua ([134.249.139.101]) by smtp.gmail.com with ESMTPSA id 13sm2534941ljb.57.2017.02.17.05.22.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2017 05:22:32 -0800 (PST) Sender: Alexander Motin Subject: Re: svn commit: r313854 - head/sys/cam/ctl To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702170522.v1H5MwGK027647@repo.freebsd.org> <20170217102408.GA74901@brick> From: Alexander Motin Message-ID: <653994e0-b49f-21ac-3bdc-d6fc34496b29@FreeBSD.org> Date: Fri, 17 Feb 2017 15:22:30 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170217102408.GA74901@brick> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 13:22:36 -0000 On 17.02.2017 12:24, Edward Tomasz Napierała wrote: > On 0217T0522, Alexander Motin wrote: >> Author: mav >> Date: Fri Feb 17 05:22:58 2017 >> New Revision: 313854 >> URL: https://svnweb.freebsd.org/changeset/base/313854 >> >> Log: >> Change the way MaxCmdSN is used. >> >> Before this change MaxCmdSN was reported as CmdSN + delta, that made it >> limit number of requests in transmission from the initiator to target, >> that was pretty useless. After this change MaxCmdSN limits number of >> requests queued to CTL, i.e. maximal queue depth for the initiator. >> The default limit is 256 outstanding requests per initiator at a time. >> >> This code uses existing cs_outstanding_ctl_pdus counter to track queue >> depth. It's semantics doen't perfectly match, but close enough to not >> add another counter. Just don't set the maxtags below 2. > > I like the change in principle, but I don't like the gratuitous change > of sysctl name. It will break people's configs. Could you rename it > back? Thanks! But its meaning is different now. Do you know anybody tuning the old sysctl? I can't imagine who would do it and what for. -- Alexander Motin