From owner-svn-src-all@FreeBSD.ORG Wed Aug 28 10:25:12 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7DB10157; Wed, 28 Aug 2013 10:25:12 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vc0-x232.google.com (mail-vc0-x232.google.com [IPv6:2607:f8b0:400c:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 079332B7E; Wed, 28 Aug 2013 10:25:11 +0000 (UTC) Received: by mail-vc0-f178.google.com with SMTP id ha12so3847653vcb.37 for ; Wed, 28 Aug 2013 03:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=MB3JHRzTy7PpdCFCDsAEw7sGY1LCQzoYlFb00GFwNaY=; b=B0RkphoqOqOQIe2lmxxeVvJnl+nySK7oUKpD6Tz0GuibjWNkK8L7rs3ag0ghT4514W gGwN9tvplcyHcZXF4frMJpDSQTjG3Z7yDTDjwYoDbSRB4b5a5+hc7sDsvBcv7yoJQ4ao wAEoCWiUGwaZ4Zc32oqVD6p908R/lbA/sPhR0xPcLyI3fyaLxvt45DQlLszSpObs2kQ7 ATHl28c2pNrGEPgfZWWn+1hZFbz5fv/nkktIFqVRE47HPetEX7ku/zx7DGB3cFmX2K8V AEOeiw9Ikf+yb2brB2mOBI0lcTYgs99aCp50JewcDNjLDp3f7NnTsz5RBRyWpniXio4l RVTA== MIME-Version: 1.0 X-Received: by 10.221.64.17 with SMTP id xg17mr24872997vcb.5.1377685511109; Wed, 28 Aug 2013 03:25:11 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.65.132 with HTTP; Wed, 28 Aug 2013 03:25:11 -0700 (PDT) In-Reply-To: <201308281006.r7SA6KSq010737@svn.freebsd.org> References: <201308281006.r7SA6KSq010737@svn.freebsd.org> Date: Wed, 28 Aug 2013 12:25:11 +0200 X-Google-Sender-Auth: i0WTERanWmAyt2_bu1hZ2UJGSXU Message-ID: Subject: Re: svn commit: r254986 - head/sys/ufs/ufs From: Davide Italiano To: Ivan Voras Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Aug 2013 10:25:12 -0000 On Wed, Aug 28, 2013 at 12:06 PM, Ivan Voras wrote: > Author: ivoras > Date: Wed Aug 28 10:06:20 2013 > New Revision: 254986 > URL: http://svnweb.freebsd.org/changeset/base/254986 > > Log: > Take a very small step toward the Century of the Anchovy by increasing the > time dirhash entries stay in memory before being considered for eviction to > 1 minute. > > Modified: > head/sys/ufs/ufs/ufs_dirhash.c > > Modified: head/sys/ufs/ufs/ufs_dirhash.c > ============================================================================== > --- head/sys/ufs/ufs/ufs_dirhash.c Wed Aug 28 07:48:44 2013 (r254985) > +++ head/sys/ufs/ufs/ufs_dirhash.c Wed Aug 28 10:06:20 2013 (r254986) > @@ -85,7 +85,7 @@ SYSCTL_INT(_vfs_ufs, OID_AUTO, dirhash_d > static int ufs_dirhashlowmemcount = 0; > SYSCTL_INT(_vfs_ufs, OID_AUTO, dirhash_lowmemcount, CTLFLAG_RD, > &ufs_dirhashlowmemcount, 0, "number of times low memory hook called"); > -static int ufs_dirhashreclaimage = 5; > +static int ufs_dirhashreclaimage = 60; > SYSCTL_INT(_vfs_ufs, OID_AUTO, dirhash_reclaimage, CTLFLAG_RW, > &ufs_dirhashreclaimage, 0, > "max time in seconds of hash inactivity before deletion in low VM events"); Hi, do you have any evidence that this change impacts positively (or negatively) performances for some workloads? If yes, can you share? Also, why did you choose the '60' value (rather than something else)? I don't see any 'Reviewed by:' line in your commit message neither I remember a public discussion on -current or -arch or -fs about this. OTOH I think such changes deserve a wider discussion. Thanks, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare