From owner-freebsd-python@freebsd.org Thu Jun 29 11:04:54 2017 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 702F5D9A0A2 for ; Thu, 29 Jun 2017 11:04:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 564EC8023E for ; Thu, 29 Jun 2017 11:04:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 55856D9A0A1; Thu, 29 Jun 2017 11:04:54 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55209D9A0A0 for ; Thu, 29 Jun 2017 11:04:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3AB7E8023D for ; Thu, 29 Jun 2017 11:04:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5TB4r7J014536 for ; Thu, 29 Jun 2017 11:04:54 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 219687] [NEW PORT] net/google-compute-engine: User daemon for Google Compute Engine Date: Thu, 29 Jun 2017 11:04:53 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: koobs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc bug_status short_desc flagtypes.name keywords priority assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 11:04:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219687 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |python@FreeBSD.org Status|New |Open Summary|[NEW PORT] |[NEW PORT] |net/google-compute-engine: |net/google-compute-engine: |user daemon for Google |User daemon for Google |Compute Engine |Compute Engine Flags| |maintainer-feedback?(helen. | |koike@collabora.com) Keywords| |feature, needs-patch, | |needs-qa Priority|--- |Normal Assignee|freebsd-ports-bugs@FreeBSD. |koobs@FreeBSD.org |org | --- Comment #8 from Kubilay Kocak --- Thank you for your new port contribution Helen. Pending further review, initial review items (needing updated patch) are: - Add missing PKGNAMEPREFIX=3D${PYTHON_PKGNAMEPREFIX} - Missing secondary 'python' virtual category in CATEGORIES=20 - Add USE_PYTHON=3Dconcurrent if the port is multiple python version concur= rent installation safe (all files are uniquely named and dont conflict) - Use 'CHEESESHOP' (PyPI) as MASTER_SITES unless there is a compelling reas= on not to (for instance, test or other important files missing from source distribution on PyPI) - Add test support (using do-test: target), adding TEST_DEPENDS (py.test, e= tc as per setup.py/tox.ini) and executing ${PYTHON_CMD} -m pytest or ${PYTHON_= CMD} setup.py test if supported. It's OK if not all test dependencies have been ported yet, just add the ones that have, adding comments for the ones that havent. - setuptools appears (in setup.py) as an install_requires (RUN_DEPENDS) not= a setup_requires (BUILD_DEPENDS) as in the patch. I don't know why its explic= itly in install_requires though. - Add LICENSE_FILE=3D${WRKSRC}/path/to/license when one exists in the distribution file - netifaces/netaddr don't appear as setup.py (compulsory) or tox.ini (potentially optional) dependencies. Can you elaborate on their source and function? If possible (highly desirable/recommended), please provide as an attachment= the results of the package test suite as well. For more information on creating ports for Python packages, see: https://wiki.freebsd.org/Python/PortsPolicy --=20 You are receiving this mail because: You are on the CC list for the bug.=