Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Oct 2016 00:12:29 -0600
From:      Adam Weinberger <adamw@adamw.org>
To:        "Tobias C. Berner" <tcberner@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r424182 - in head: Mk Mk/Uses accessibility/jovie accessibility/kaccessible accessibility/kmag accessibility/kmousetool accessibility/kmouth archivers/ark astro/kstars astro/marble audi...
Message-ID:  <73BDBF7D-18B3-46DB-96E1-977A5580BE8C@adamw.org>
In-Reply-To: <201610181722.u9IHMa0t093801@repo.freebsd.org>
References:  <201610181722.u9IHMa0t093801@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> On 18 Oct, 2016, at 11:22, Tobias C. Berner <tcberner@freebsd.org> =
wrote:
>=20
> Author: tcberner
> Date: Tue Oct 18 17:22:35 2016
> New Revision: 424182
> URL: https://svnweb.freebsd.org/changeset/ports/424182
>=20
> Log:
>  Introduce new extensible virtual categories for KDE
>=20
>  A lot of KDE Ports share MASTERSITES, LICENSE and so one, as they are
>  released as a bundle upstream, however, there was not really a clean
>  way to share this information.
>=20
>  Using these new categories, we can simplify the Makefiles for the =
diverse
>  KDE ports.
>  At the moment we support the virtual category
>  	* kde-kde4
>  In the future, this will be extended to
>  	* kde-frameworks
>  	* kde-plasma
>  	* kde-applications
>=20
>  PR:						213406
>  Differential Revision:	https://reviews.freebsd.org/D7645
>  Exp-run by :			antoine
>  Reviewed by:			mat, rakuco
>  Approved by: 			portmgr (mat), rakuco (mentor)
>=20

I hate to be that guy, but....

Are you sure that turning category into a magical setting is the best =
way to go? Category has never been magical before, and it sets a whole =
new precedent (until now, "Why aren't my distfiles showing up where I =
expect?" has never been answered with "CATEGORY").

Wouldn't something like
	USES=3D	kde:dist-kde4
be a more predictable way of doing this?

USES enables magic. CATEGORY sets the category. Do we really want to =
change that?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73BDBF7D-18B3-46DB-96E1-977A5580BE8C>