From owner-freebsd-hackers@freebsd.org  Thu Jul 28 15:59:28 2016
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42BFDBA75C2
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Thu, 28 Jul 2016 15:59:28 +0000 (UTC)
 (envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 062D21D90
 for <freebsd-hackers@freebsd.org>; Thu, 28 Jul 2016 15:59:28 +0000 (UTC)
 (envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.sbone.de (Postfix) with ESMTPS id F34A625D3857;
 Thu, 28 Jul 2016 15:59:23 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
 [IPv6:fde9:577b:c1a9:31::2013:2742])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPS id 19FC5D1F880;
 Thu, 28 Jul 2016 15:59:23 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
 by content-filter.sbone.de (content-filter.sbone.de
 [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
 with ESMTP id 6cqp2vGjRZ3l; Thu, 28 Jul 2016 15:59:22 +0000 (UTC)
Received: from [10.248.105.13] (fresh-tun0-ula.sbone.de
 [IPv6:fde9:577b:c1a9:4920:2ef0:eeff:fe03:ee34])
 (using TLSv1 with cipher AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPSA id C19D1D1F87F;
 Thu, 28 Jul 2016 15:59:21 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To: "Christian Mauderer" <christian.mauderer@embedded-brains.de>
Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>
Subject: Re: Changes to pfctl to allow easier integration into a library
Date: Thu, 28 Jul 2016 15:59:20 +0000
Message-ID: <B2EA8BF5-115F-48D0-9561-68D3AE4642CD@lists.zabbadoz.net>
In-Reply-To: <25df9fd5-be75-b9ae-aa3a-22abef3bddf0@embedded-brains.de>
References: <25df9fd5-be75-b9ae-aa3a-22abef3bddf0@embedded-brains.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mailer: MailMate (2.0BETAr6042)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jul 2016 15:59:28 -0000

On 28 Jul 2016, at 14:03, Christian Mauderer wrote:

> Hello,
>
> I'm currently working on a porting pfctl to a real-time operating
> system. This is done using the same framework that Sebastian Huber
> mentioned here (and probably at some other occasions):
>
…
> Would the attached patches be acceptable for integration into the
> FreeBSD sources?

Hi,

(a) I’d prefer uintX_t to u_intX_t and I think FreeBSD is using the 
former generally.

(b) All the variables you pulled out of functions that are not const, 
would need to be virtualised for VIMAGE, as otherwise one virtual 
network stack could affect another.

Would you be willing to look into this?

Gruesse
/bz