From owner-cvs-all Sun Jan 26 10:25:39 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 089AF37B401; Sun, 26 Jan 2003 10:25:37 -0800 (PST) Received: from out1.mx.nwbl.wi.voyager.net (out1.mx.nwbl.wi.voyager.net [169.207.3.119]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A66B43F18; Sun, 26 Jan 2003 10:25:37 -0800 (PST) (envelope-from silby@silby.com) Received: from [10.1.1.6] (d34.as7.nwbl0.wi.voyager.net [169.207.128.162]) by out1.mx.nwbl.wi.voyager.net (Postfix) with ESMTP id F37E4E7C7B; Sun, 26 Jan 2003 12:24:11 -0600 (CST) Date: Sun, 26 Jan 2003 12:32:01 -0600 (CST) From: Mike Silbersack To: phk@freebsd.org Cc: cvs-committers@freebsd.org, "" Subject: Re: cvs commit: src/sbin/md5 md5.c In-Reply-To: <5470.1043572717@critter.freebsd.dk> Message-ID: <20030126122840.T2254-100000@patrocles.silby.com> References: <5470.1043572717@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 26 Jan 2003 phk@freebsd.org wrote: > In message <200301260823.h0Q8NbQJ031213@repoman.freebsd.org>, Mike Silbersack w > rites: > >silby 2003/01/26 00:23:37 PST > > > > Modified files: > > sbin/md5 md5.c > > Log: > > Change the -x option so that it does an actual REAL test of > > the correctness of this program. Previously, it printed out > > the MD5 values of some test strings, but did not tell you > > if they were correct or not! > > Uhm, this is pretty pointless, regression tests are already > properly implemented over in src/lib/libmd... > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 Nonetheless, I think it's better to have the -x option actually do something; I was playing with libmd, and it rather annoyed me that md5 -x never reported any errors when I intentionally caused them. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message