From owner-svn-src-head@freebsd.org Thu Nov 17 19:23:45 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11376C4757E; Thu, 17 Nov 2016 19:23:45 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C2E34151B; Thu, 17 Nov 2016 19:23:44 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::1d64:fe7e:bf43:65ca] (unknown [IPv6:2001:7b8:3a7:0:1d64:fe7e:bf43:65ca]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D7A79F5D8; Thu, 17 Nov 2016 20:23:40 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_298B0D63-2035-422A-B34B-C42275DE7318"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r308664 - in head: contrib/hyperv/tools etc/devd etc/mtree include share/man/man4 sys/conf sys/dev/hyperv/utilities sys/modules/hyperv/utilities usr.sbin/hyperv usr.sbin/hyperv/tools us... From: Dimitry Andric In-Reply-To: Date: Thu, 17 Nov 2016 20:23:28 +0100 Cc: Mark Johnston , Sepherosa Ziehau , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: References: <201611150236.uAF2aCV8015106@repo.freebsd.org> <20161116221440.GA83880@wkstn-mjohnston.west.isilon.com> To: Ngie Cooper X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 19:23:45 -0000 --Apple-Mail=_298B0D63-2035-422A-B34B-C42275DE7318 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 17 Nov 2016, at 01:31, Ngie Cooper wrote: > > On Wed, Nov 16, 2016 at 2:14 PM, Mark Johnston wrote: > ... >> This appears to install hv_kvp_daemon and hv_vss_daemon to / instead of >> /usr/sbin, and breaks the -DNO_ROOT build. I think a Makefile.inc is >> needed in usr.sbin/hyperv/tools in order to preserve BINDIR from >> usr.sbin/Makefile.inc. I fixed the problem in my tree with the diff >> below, but am not sure if this is the right way to do it. For some >> reason, doing this resulted in unused var warnings compiling >> hv_vss_daemon.c. > > The -Wunused warnings you're seeing are because you're now it's > setting WARNS by .include'ing usr.bin/Makefile.inc ; it used to be set > (I verified that), but then got unset between a few weeks ago and now > on the directory: > > $ make -V.CURDIR -VWARNS > /usr/src/usr.sbin/hyperv/tools > > $ > > Cheers, > -Ngie > > PS -Wno-uninitialized is only set for gcc...? Really...??? Yes, because base gcc has produced many false positives with its -Wuninitialized warnings. In fact, I would suggest that is globally turned off for any gcc version before 4.7. -Dimitry --Apple-Mail=_298B0D63-2035-422A-B34B-C42275DE7318 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlguA78ACgkQsF6jCi4glqPt9ACg4ZUbfFmnLfKJechINmWtv+e6 UNgAoLcZU5VebYLSWZpenkyjaz4ED7fm =wfLC -----END PGP SIGNATURE----- --Apple-Mail=_298B0D63-2035-422A-B34B-C42275DE7318--