From owner-svn-src-head@FreeBSD.ORG Thu Nov 10 06:24:18 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D452106564A; Thu, 10 Nov 2011 06:24:18 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 3E8398FC17; Thu, 10 Nov 2011 06:24:18 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 9D1145B; Thu, 10 Nov 2011 07:24:15 +0100 (CET) Date: Thu, 10 Nov 2011 07:23:23 +0100 From: Pawel Jakub Dawidek To: Kostik Belousov Message-ID: <20111110062322.GA1696@garage.freebsd.pl> References: <201111091725.pA9HPhXh092218@svn.freebsd.org> <20111109173128.GF50300@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <20111109173128.GF50300@deviant.kiev.zoral.com.ua> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227394 - in head/sys: amd64/amd64 i386/i386 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2011 06:24:18 -0000 --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 09, 2011 at 07:31:28PM +0200, Kostik Belousov wrote: > On Wed, Nov 09, 2011 at 05:25:43PM +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Wed Nov 9 17:25:43 2011 > > New Revision: 227394 > > URL: http://svn.freebsd.org/changeset/base/227394 > >=20 > > Log: > > Stopped process may legitimately have some threads sleeping and not > > suspended, if the sleep is uninterruptible. > Even more, stopped process might have some threads still running in the > kernel mode, or inhibited due to wait on blockable locks. I was unable > to design an expression that would assert that such thread will be stopped > at the kernel->user boundary. >=20 > The assertion itself is useful and catched several bugs, but theoretically > can cause false positives. If any report of the fired assert for kernel-m= ode > thread is provided, I will remove the assertions. If in five years some change will make it to fire and you won't be around, nobody will remember this e-mail of yours and someone will spend time on looking for a bug that doesn't exist. If we know it can cause false positives, I'd be in favour of removing it or changing it into a warning or at the very least moving this information into commit log. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk67bdoACgkQForvXbEpPzTLvwCg4Iqm65F8LtbXFirnK6zmcoPd d+wAn36S8Mj3S65ThbLyEWwnalvSoQDy =5qir -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--