From owner-svn-src-all@FreeBSD.ORG Wed Sep 24 15:27:15 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A99C5412 for ; Wed, 24 Sep 2014 15:27:15 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 70533CEE for ; Wed, 24 Sep 2014 15:27:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id s8OFRF6W091779 for ; Wed, 24 Sep 2014 15:27:15 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s8OFRFgP091772 for svn-src-all@freebsd.org; Wed, 24 Sep 2014 15:27:15 GMT (envelope-from bdrewery) Received: (qmail 99404 invoked from network); 24 Sep 2014 10:27:13 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 24 Sep 2014 10:27:13 -0500 Message-ID: <5422E2CA.6050000@FreeBSD.org> Date: Wed, 24 Sep 2014 10:27:06 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: John Baldwin Subject: Re: svn commit: r272032 - head/sys/conf References: <201409231704.s8NH4Lcv098184@svn.freebsd.org> <1598020.ur8YbI6DkF@ralph.baldwin.cx> In-Reply-To: <1598020.ur8YbI6DkF@ralph.baldwin.cx> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sBNWcvLaCLMcwBv7o5CTqumiTwVqjqX3n" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2014 15:27:15 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sBNWcvLaCLMcwBv7o5CTqumiTwVqjqX3n Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 9/24/2014 8:38 AM, John Baldwin wrote: > On Tuesday, September 23, 2014 05:04:21 PM Bryan Drewery wrote: >> Author: bdrewery >> Date: Tue Sep 23 17:04:21 2014 >> New Revision: 272032 >> URL: http://svnweb.freebsd.org/changeset/base/272032 >> >> Log: >> DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use= it. >> fstat(1) now uses libprocstat(9). There is no userland impact to us= ing >> this. >=20 > As your followup noted, it does change the size of 'struct lock' (and t= hus > 'struct vnode') still. While fstat does not use it for live, it probab= ly > still uses it for coredumps. However, lsof uses kvm access, so it will= break. > I don't think that is worth noting here, but more of an FYI. >=20 Hmm, I see my commit logs were not fully accurate. I was too focused on the stale comment about fstat(1). --=20 Regards, Bryan Drewery --sBNWcvLaCLMcwBv7o5CTqumiTwVqjqX3n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUIuLKAAoJEDXXcbtuRpfPCf0H/jMFpK2eaP3iC6MQD3uLvUnB Bn67mKToZ7q8YC9rli/sdNfjjgxwU5A+8rrw95cMSW37PEVZlZMqzzkfWegFi6Hf 5hViMnQLAxD1LNuYXIdcwh9DQbB0YI4E5SXkaXC5z9xGKOoVx8OVcLoJvTBrk23g aFW810OkMD6hdNo3B46vHgW7PyKFHg9idnTdTx6jbhkK0ILn/ssIg5QkrfrMW17i DYLJmGvxkOGF/a2JcF7Rhy+FHcGx17S4t2LQ9UOymqrqmfqT6dy0HSD8JHOqrOJH 4Ben8Qz8PNxwSkSBjn8MzZc65uOTYW8ZsitW0bRR5aGyV8ZhAaaYv4HfMoCJTFk= =NFEc -----END PGP SIGNATURE----- --sBNWcvLaCLMcwBv7o5CTqumiTwVqjqX3n--