Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2025 20:49:37 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 2632e532c431 - stable/14 - TCP BBR: simplify expression
Message-ID:  <202502052049.515Knb78085810@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=2632e532c431b3ebb1320a50b5ab78f9f24f3627

commit 2632e532c431b3ebb1320a50b5ab78f9f24f3627
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-01-04 14:25:01 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-05 09:49:42 +0000

    TCP BBR: simplify expression
    
    There is no need to check partially for bbr->r_ctl.crte being NULL,
    since this can't be true in this path.
    No functional change intended.
    
    Reviewed by:            rrs
    CID:                    1523810
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D48312
    
    (cherry picked from commit 305c40dc552f9c150eacce95c181798031368cd9)
---
 sys/netinet/tcp_stacks/bbr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c
index 1d030230748f..144b3f25e9c7 100644
--- a/sys/netinet/tcp_stacks/bbr.c
+++ b/sys/netinet/tcp_stacks/bbr.c
@@ -5542,7 +5542,7 @@ lost_rate:
 		bbr_type_log_hdwr_pacing(bbr,
 					 bbr->r_ctl.crte->ptbl->rs_ifp,
 					 rate,
-					 ((bbr->r_ctl.crte == NULL) ? 0 : bbr->r_ctl.crte->rate),
+					 bbr->r_ctl.crte->rate,
 					 __LINE__,
 					 cts,
 					 error);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502052049.515Knb78085810>