From owner-svn-src-head@freebsd.org Wed Jun 20 00:54:19 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B2351019EB8 for ; Wed, 20 Jun 2018 00:54:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2B9A77E86E for ; Wed, 20 Jun 2018 00:54:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x241.google.com with SMTP id p185-v6so3149760itp.4 for ; Tue, 19 Jun 2018 17:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=em2iGhZTNWLrOktCjNXOG+Zl/rBofwrWeFVpUN66HZo=; b=WSe60ucVzm2TKScAOlJl8huQaExWdzA4Qo5+szVlBRyVzqiir4nfWivoITUI4iDLof qLlipUlctJvSecVHeYQTDQKxwJ+FaBzxlQc0tF+NSHY1p/mMJ0j3L41JoEMZAVDMSwqZ 4G6o+tTDhHs0JIrpuJmv8jUoAQabuI0t659EFfy4d5cYxYmxgsy3LWYZ5s1QNJ9ChzAS UeRmcW3ALXmuSv2XO13TrZeT/+MEngqTvhhfxuye8XNaH7CK0/aMtRdhkyq+szofyYcd VokE7C8Fu/WExPbFwhPK33fW+/Abx6JaMvMJ5f4JK4CaArjbvSBLilvj4Azr6QRkR0qy PDSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=em2iGhZTNWLrOktCjNXOG+Zl/rBofwrWeFVpUN66HZo=; b=RmaB8R/eeo/KsfJUsFW+1yIaHcBeCph1JGwAmvJfC5ip0U/YDeEwA1CTTdwHAnlOGP IslRVE63xd/j10AxX+oCy/ytzhQT/QqWtXkDn+O/hvwVaLdxQ2xoN4J6S0SL9j3BOMye AAi/0WPPiH53dDEOEugY6fkNR6UuGZDaf+p2Za8TKMO1LCyXMHluMEZS5DEGi1piG264 BALM75SA1Py5M0b97LBheSM9jDlwUJkjR7eP0DlII4rhl3nRZIuCd03f2W5nhC1oPl0k RfwcTQ4PRnaQgwdhev+x/Y4ChQ0k/vL/RDEaF/XTbLLuLSPyKhWcckxuF8IQ40xgibhG djGQ== X-Gm-Message-State: APt69E2ICDTgb2h2M66hay2eFV8ScIVqIeMSa9o9KaoaT0hPRQ/NY+tt BigaIe2P3NIMmO4GkB9bvMg1f69CireCn/Ul+eCEdA== X-Google-Smtp-Source: ADUXVKK4NXdOGdqJvIjq/Y5rsyy4lT7+RMQldrX8qhToah4chXqWlg0mG7zhr3iSBZNfbopRUmtHNeSZqLt+bpICECQ= X-Received: by 2002:a24:7c8d:: with SMTP id a135-v6mr14799212itd.73.1529456057792; Tue, 19 Jun 2018 17:54:17 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:5945:0:0:0:0:0 with HTTP; Tue, 19 Jun 2018 17:54:17 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201806170514.w5H5Epts050842@repo.freebsd.org> <77224f10-7633-1122-8099-466f2a35942f@FreeBSD.org> <4ad7ef96-e623-5ab8-dc47-c3178115ff24@FreeBSD.org> From: Warner Losh Date: Tue, 19 Jun 2018 18:54:17 -0600 X-Google-Sender-Auth: MPtHmvbwNVRa9OhgMs09rTh2otw Message-ID: Subject: Re: svn commit: r335278 - head/bin/pwd To: Eitan Adler Cc: Pedro Giffuni , John Baldwin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 00:54:19 -0000 On Tue, Jun 19, 2018 at 5:56 PM, Eitan Adler wrote: > On 19 June 2018 at 12:57, Pedro Giffuni wrote: > > > > > > On 19/06/2018 11:25, John Baldwin wrote: > >> > >> On 6/18/18 10:26 PM, Eitan Adler wrote: > >>> > >>> On 18 June 2018 at 10:57, John Baldwin wrote: > >>>> > >>>> On 6/16/18 10:14 PM, Eitan Adler wrote: > >>>>> > >>>>> Author: eadler > >>>>> Date: Sun Jun 17 05:14:50 2018 > >>>>> New Revision: 335278 > >>>>> URL: https://svnweb.freebsd.org/changeset/base/335278 > >>>>> > >>>>> Log: > >>>>> pwd: mark usage as dead > >>>> > >>>> You keep committing changes like this and ignoring e-mails about them. > >>> > >>> I replied both the first time and this time. I may have > >>> (accidentally?) ignored similar emails though. The question I have is > >>> other than the mild code churn what's the harm? > >> > >> It adds clutter. Also, fixing the tool means you fix all the places at > >> once rather than slowly adding workarounds one by one. > >> > >>>> What broken compiler are you using that doesn't properly inherit > __dead2 > >>>> from the call to exit()? > >>> > >>> In this case, scan-build50 was getting annoyed. > >> > >> Does scan-build from LLVM 6.0 handle this correctly? If so, I'd say to > >> just mark this warning as broken (and thus ignore it) for scan-build50 > >> just as we ignore certain warnings from GCC 4.2.1 because they are > >> broken-as-implemented. > >> > > FWIW, clang's scan-build is made to even more false positives and general > > noise than the regular compiler warnings. > > It is better to just ignore it unless it finds something real. > > I don't consider this a real harm, but I'll try and remember to ignore > these in the future. We're in danger of being nibbled to death by ducks by these sorts of things. We need to choose carefully where we annotate to accommodate the competing needs of simplicity and automated tools providing assistance in boosting our code quality. So this one may or may not matter. But it's not just this one change that we have to look at... Warner