From owner-svn-src-all@FreeBSD.ORG Wed Feb 11 15:00:11 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 543C310656C6; Wed, 11 Feb 2009 15:00:11 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121]) by mx1.freebsd.org (Postfix) with ESMTP id 4DA8D8FC23; Wed, 11 Feb 2009 15:00:09 +0000 (UTC) (envelope-from mav@FreeBSD.org) X-Spam-Flag: SKIP X-Spam-Yversion: Spamooborona-2.1.0 Received: from orphanage.alkar.net (account mav@alkar.net [212.86.226.11] verified) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9) with ESMTPA id 234296925; Wed, 11 Feb 2009 17:00:09 +0200 Message-ID: <4992E7F8.9050509@FreeBSD.org> Date: Wed, 11 Feb 2009 17:00:08 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.14 (X11/20080612) MIME-Version: 1.0 To: John Baldwin References: <200902102322.n1ANMTgW007393@svn.freebsd.org> <200902110829.20859.jhb@freebsd.org> In-Reply-To: <200902110829.20859.jhb@freebsd.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188464 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2009 15:00:12 -0000 John Baldwin wrote: > On Tuesday 10 February 2009 6:22:29 pm Alexander Motin wrote: >> Author: mav >> Date: Tue Feb 10 23:22:29 2009 >> New Revision: 188464 >> URL: http://svn.freebsd.org/changeset/base/188464 >> >> Log: >> Check for device_set_devclass() errors and skip driver probe/attach if > any. >> Attach call without devclass set crashes the system. >> >> On resume AHCI driver sometimes tries to create duplicate adX device. >> It is surely his own problem, but IMHO it is not a reason to crash here. >> Other reasons are also possible. > > Can you describe the problem a bit more fully? Is the ata driver adding a > device with a fixed unit number but a wildcard class? (That is, it is doing > something like 'device_add_child(dev, NULL, 4)'?) Exactly. Class detected later as "ad" or as "acd", or something else. So it does not get any error on that stage. But later, on driver_probe(), device_set_devclass() returns error which left unhandled and causes later crash inside following device_attach(). -- Alexander Motin