From nobody Wed Feb 11 10:03:06 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9vBg3RlHz6SMGg for ; Wed, 11 Feb 2026 10:03:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9vBf4kXZz49Fg for ; Wed, 11 Feb 2026 10:03:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770804186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pY/8H/ckjRtaRJtuo+ortaEBlf/uWLSTLZ5J2aWrtrU=; b=dxg2trc/qKfIOPipgsjhRhcxqgJKNb8Ngmohcg3EH/UutV1WzOnjY2kqWVfK7Bbyl/4fwI KmDsFlp55aVLfo54OkPeu+gbt0l8FGyrPeVKsHpHHiCsikHa2ENwE+SHSgc/OoTInHZ1ih l8/llCM3G7iKOwmCaEFVbQWhRNq1xK1DEAxWWTx8VF6cyCdGe/mUQwSE8w89iwdPozOpB7 UzzHS4nkZ841UanKEMlSiFAPje4v/DBoIxm9n5T7/D8rISNzrONFBV5cHfv3o3CMtYrjz0 hha1M+YhJ/PTR/p66MVW9myVBlODk4fYmrNeK/PXjbNDVfxYN1XImD812M64Wg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770804186; a=rsa-sha256; cv=none; b=Jz7qpx+hGNbswyyTrUg2/x4El1yF8RIaTEfW2s1Frmd0rdjRSuHwdLWKm9q8yLNuhjJ2K2 ButXXcRRPY8Zy8TcG5wdap6lSChgPoDHG3pSxiBL+hyP1/9OCp6zkVbay087DOv0Ktq/UL MU5e1YWTCpxMtvlDqFCDd+xMndG7+SmHCTvWsO198bh8QNCCDQky2iPKzYD7RYk/QLP3GK c7MvktApH691x+5d3Zi07O0jCIgNHyUKXeQnZuWSCYtuPMifJdSHI8njAVYIzmfWNvkFBk L0wZAQVad3sn9GMjnx9WPu99kHgMreiDVAxQClAOl1uXD3eD83799ST3AZb43g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770804186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pY/8H/ckjRtaRJtuo+ortaEBlf/uWLSTLZ5J2aWrtrU=; b=SLy59kc7+xTgCy25WKhH+Kep23dlex6iHwh0rgPmoBdYycgTt2+9mYZAkd6V4SSks6awjB 3GA9CKuoamYGpu0FHWZUn/wKQeB6pGWF/pxhuB1sHq1l1s8KhKY9k7ucS7qdLmYc0On/1h 1nl8Dozr0a7rFR6V/ukuBfJ5YJcmIyym3J3XVf/SA5r8VGPd5YhkR30ldbQ75S8EHDoedw 5GbyAPhoBRt461Uc5C1ALbGCb2lB9DfQz4GE7CAeVDz9RFHyKeFrziRlaRv0L0hYL0slc1 5AvKN2KKUpGLhRDd9XOkPPJa9C21Be913pO5N0Bu/72fP/gt+usUhWjkpi304Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9vBf361nzlfT for ; Wed, 11 Feb 2026 10:03:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 199f0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 10:03:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 8731ff4871d5 - stable/15 - qlnxe: Avoid reinitializing the interface when it is already initialized List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 8731ff4871d5397bae65bf184c44629a52c0e97b Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 10:03:06 +0000 Message-Id: <698c53da.199f0.31a84e6@gitrepo.freebsd.org> The branch stable/15 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=8731ff4871d5397bae65bf184c44629a52c0e97b commit 8731ff4871d5397bae65bf184c44629a52c0e97b Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:54 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-11 10:00:43 +0000 qlnxe: Avoid reinitializing the interface when it is already initialized qlnx_init_locked() unconditionally uninitialize the interface thus is actually reinitializing the interface. Well the init routine qlnx_init() is to initialize the interface by net stack when assigned with the first inet or inet6 address. The ioctl SIOCSIFADDR for the first inet6 address is handled by ether_ioctl() thus the interface is reinitialized no matter it was initialized or not. Add a driver status check for that to avoid reinitializing. Further plan is removing SIOCSIFADDR ioctl from the driver and let ether_ioctl() handle it. Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54887 (cherry picked from commit c10e6bc0f0079e90cb484323ad71d437f1882422) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index b0dac3a82582..bc0282e3c22b 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2431,7 +2431,8 @@ qlnx_init(void *arg) QL_DPRINT2(ha, "enter\n"); QLNX_LOCK(ha); - qlnx_init_locked(ha); + if ((if_getdrvflags(ha->ifp) & IFF_DRV_RUNNING) == 0) + qlnx_init_locked(ha); QLNX_UNLOCK(ha); QL_DPRINT2(ha, "exit\n");