From owner-svn-src-all@freebsd.org  Mon May 16 20:07:05 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C36CDB3EF92;
 Mon, 16 May 2016 20:07:05 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: from mail-yw0-f174.google.com (mail-yw0-f174.google.com
 [209.85.161.174])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8E1AD1B3A;
 Mon, 16 May 2016 20:07:05 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: by mail-yw0-f174.google.com with SMTP id g133so173088922ywb.2;
 Mon, 16 May 2016 13:07:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:reply-to:in-reply-to:references
 :date:message-id:subject:from:to:cc;
 bh=voZtJY+sFNFFPzWJh8Cr3yJlqpA/K0Gl+zEY24ZGm+o=;
 b=dPyDOYDsAVgeHWiy4T2kZ/3985yunj3i+oFgMk9YVjDlMgDzmUSJeKFxkAa2+tAAyU
 bBmiILRh3RJfeM4TJvUyMAv7aIbZbwxUArevGp0R2NYqyFQX35RkKNad20NzeZuZDTeK
 nl7hTrt6m/UN4dKta/4i53/BBMDPVq92DU3u4Bkh8ZISlftx7k1jygoHUi8WHdpVlhGH
 UDrY5Cr5bsW8kEh1U9BWTxng/S9Uckny8zl99/7pnLacnHCNLGKlPjQFjxBETDDKhj33
 5sCINo/Cih0NxGlYQSAK4ngT+yopdr4aMy0r12qnV8BMNgIc554ihTXmHxI1RUD+4uwi
 oNOw==
X-Gm-Message-State: AOPr4FW+jadHAeeZjaavNcPfkJcX6IyL+TeH49rC1tzKGBZ6M8Cmgh2Tnn+vB+ovD0FYww==
X-Received: by 10.37.214.83 with SMTP id n80mr14730738ybg.90.1463414013735;
 Mon, 16 May 2016 08:53:33 -0700 (PDT)
Received: from mail-oi0-f45.google.com (mail-oi0-f45.google.com.
 [209.85.218.45])
 by smtp.gmail.com with ESMTPSA id l132sm19612656ywb.26.2016.05.16.08.53.33
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 16 May 2016 08:53:33 -0700 (PDT)
Received: by mail-oi0-f45.google.com with SMTP id v145so273948845oie.0;
 Mon, 16 May 2016 08:53:33 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.202.240.68 with SMTP id o65mr17963772oih.0.1463414012920;
 Mon, 16 May 2016 08:53:32 -0700 (PDT)
Reply-To: cem@FreeBSD.org
Received: by 10.157.19.20 with HTTP; Mon, 16 May 2016 08:53:32 -0700 (PDT)
In-Reply-To: <201605160916.u4G9GFLl013293@repo.freebsd.org>
References: <201605160916.u4G9GFLl013293@repo.freebsd.org>
Date: Mon, 16 May 2016 08:53:32 -0700
X-Gmail-Original-Message-ID: <CAG6CVpV7SfWHtgL_gX5y+QCMiCtXFoNsrTaY1q7+AyqQbn1dhg@mail.gmail.com>
Message-ID: <CAG6CVpV7SfWHtgL_gX5y+QCMiCtXFoNsrTaY1q7+AyqQbn1dhg@mail.gmail.com>
Subject: Re: svn commit: r299930 - in head/sys/compat/linuxkpi/common:
 include/linux src
From: Conrad Meyer <cem@FreeBSD.org>
To: Hans Petter Selasky <hselasky@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 May 2016 20:07:05 -0000

On Mon, May 16, 2016 at 2:16 AM, Hans Petter Selasky
<hselasky@freebsd.org> wrote:
> Author: hselasky
> Date: Mon May 16 09:16:15 2016
> New Revision: 299930
> URL: https://svnweb.freebsd.org/changeset/base/299930
>
> Log:
>   Properly implement "cpu_has_clflush" macro.
> ...
> @@ -51,6 +51,10 @@ __FBSDID("$FreeBSD$");
>
>  #include <machine/stdarg.h>
>
> +#if defined(__i386__) || defined(__amd64__)
> +#include <machine/md_var.h>
> +#endif
> +
>  #include <linux/kobject.h>
>  #include <linux/device.h>
>  #include <linux/slab.h>
> @@ -67,6 +71,7 @@ __FBSDID("$FreeBSD$");
>  #include <linux/rcupdate.h>
>  #include <linux/interrupt.h>
>  #include <linux/uaccess.h>
> +#include <linux/kernel.h>

Hi Hans,

In Linux code, usually linux/kernel.h is included first.  In FreeBSD,
we mostly sort alphabetically.  Pick a system, but this is the wrong
place for this include :-).

Best,
Conrad