Date: Mon, 16 May 2016 08:53:32 -0700 From: Conrad Meyer <cem@FreeBSD.org> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299930 - in head/sys/compat/linuxkpi/common: include/linux src Message-ID: <CAG6CVpV7SfWHtgL_gX5y%2BQCMiCtXFoNsrTaY1q7%2BAyqQbn1dhg@mail.gmail.com> In-Reply-To: <201605160916.u4G9GFLl013293@repo.freebsd.org> References: <201605160916.u4G9GFLl013293@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 16, 2016 at 2:16 AM, Hans Petter Selasky <hselasky@freebsd.org> wrote: > Author: hselasky > Date: Mon May 16 09:16:15 2016 > New Revision: 299930 > URL: https://svnweb.freebsd.org/changeset/base/299930 > > Log: > Properly implement "cpu_has_clflush" macro. > ... > @@ -51,6 +51,10 @@ __FBSDID("$FreeBSD$"); > > #include <machine/stdarg.h> > > +#if defined(__i386__) || defined(__amd64__) > +#include <machine/md_var.h> > +#endif > + > #include <linux/kobject.h> > #include <linux/device.h> > #include <linux/slab.h> > @@ -67,6 +71,7 @@ __FBSDID("$FreeBSD$"); > #include <linux/rcupdate.h> > #include <linux/interrupt.h> > #include <linux/uaccess.h> > +#include <linux/kernel.h> Hi Hans, In Linux code, usually linux/kernel.h is included first. In FreeBSD, we mostly sort alphabetically. Pick a system, but this is the wrong place for this include :-). Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpV7SfWHtgL_gX5y%2BQCMiCtXFoNsrTaY1q7%2BAyqQbn1dhg>