From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Apr 8 13:20:13 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0831E1065698 for ; Sun, 8 Apr 2012 13:20:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0EEBE8FC2F for ; Sun, 8 Apr 2012 13:20:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q38DK8DX094624 for ; Sun, 8 Apr 2012 13:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q38DK8b2094623; Sun, 8 Apr 2012 13:20:08 GMT (envelope-from gnats) Resent-Date: Sun, 8 Apr 2012 13:20:08 GMT Resent-Message-Id: <201204081320.q38DK8b2094623@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pierre Guinoiseau Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4DBE5106566B for ; Sun, 8 Apr 2012 13:15:53 +0000 (UTC) (envelope-from pierre@home.poildetroll.net) Received: from kashyyyk.home.poildetroll.net (kashyyyk.home.poildetroll.net [IPv6:2001:910:10b7:f00::1]) by mx1.freebsd.org (Postfix) with ESMTP id BFF188FC15 for ; Sun, 8 Apr 2012 13:15:52 +0000 (UTC) Received: from alderaan.home.poildetroll.net (alderaan.home.poildetroll.net [IPv6:2001:910:10b7:f00:6ef0:49ff:fe5e:e54c]) by kashyyyk.home.poildetroll.net (Postfix) with ESMTP id 2C4C8F302E for ; Sun, 8 Apr 2012 15:15:43 +0200 (CEST) Received: by alderaan.home.poildetroll.net (Postfix, from userid 1001) id DCC11970; Sun, 8 Apr 2012 15:15:42 +0200 (CEST) Message-Id: <20120408131542.DCC11970@alderaan.home.poildetroll.net> Date: Sun, 8 Apr 2012 15:15:42 +0200 (CEST) From: Pierre Guinoiseau To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/166753: [patch] lang/lua: missing Lua features because of CFLAGS override by port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pierre Guinoiseau List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Apr 2012 13:20:13 -0000 >Number: 166753 >Category: ports >Synopsis: [patch] lang/lua: missing Lua features because of CFLAGS override by port >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Apr 08 13:20:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Pierre Guinoiseau >Release: FreeBSD 9.0-STABLE amd64 >Organization: >Environment: System: FreeBSD alderaan.home.poildetroll.net 9.0-STABLE FreeBSD 9.0-STABLE #0 r233766M: Mon Apr 2 02:55:14 CEST 2012 root@alderaan.home.poildetroll.net:/usr/obj/usr/src/sys/ALDERAAN amd64 >Description: Hi, I have had a strange problem after updating lang/lua (and even rebuilding the previous version): some functionalities like popen() and dynamic libraries were not enabled. I've found out after rebuilding it by hand that -DLUA_USE_LINUX (which enables popen, dlopen, etc. according to luaconf.h) was not defined when compiling with the port: by hand: cd src && make freebsd make all MYCFLAGS="-DLUA_USE_LINUX" MYLIBS="-Wl,-E -lreadline" cc -O2 -pipe -march=nocona -fPIC -march=core2 -Wall -DLUA_USE_LINUX -c lapi.c cc -O2 -pipe -march=nocona -fPIC -march=core2 -Wall -DLUA_USE_LINUX -c lcode.c cc -O2 -pipe -march=nocona -fPIC -march=core2 -Wall -DLUA_USE_LINUX -c ldebug.c cc -O2 -pipe -march=nocona -fPIC -march=core2 -Wall -DLUA_USE_LINUX -c ldo.c ... by port: cd src && make freebsd make all MYCFLAGS="-DLUA_USE_LINUX" MYLIBS="-Wl,-E -lreadline" cc -O2 -pipe -march=nocona -fPIC -march=core2 -c lapi.c cc -O2 -pipe -march=nocona -fPIC -march=core2 -c lcode.c cc -O2 -pipe -march=nocona -fPIC -march=core2 -c ldebug.c cc -O2 -pipe -march=nocona -fPIC -march=core2 -c ldo.c ... If you look into src/Makefile, you can see that: CFLAGS+= -Wall $(MYCFLAGS) [...] freebsd: $(MAKE) all MYCFLAGS="-DLUA_USE_LINUX" MYLIBS="-Wl,-E -lreadline" Apparently, this CFLAGS is not taken into account when building with the port. So, I tried to remove 'MAKE_ARGS=CFLAGS="${CFLAGS}"' from the port's Makefile (see attached patch), and it worked! And custom CFLAGS from make.conf are still used. Revision 1.48 of the port seems to be the origin of this problem: http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/lua/Makefile.diff?r1=1.47;r2=1.48 Regards, >How-To-Repeat: >Fix: --- lua-make-args-cflags.diff begins here --- diff -ruN --exclude=CVS ../lua.orig/Makefile ./Makefile --- ../lua.orig/Makefile 2012-04-08 14:46:22.441455000 +0200 +++ ./Makefile 2012-04-08 14:47:46.687479850 +0200 @@ -24,7 +24,6 @@ USE_LDCONFIG= yes MAKE_JOBS_SAFE= yes MAKE_ENV= LUA_SONAME="liblua-${LUA_VER}.so.${LUA_VER_SH}" -MAKE_ARGS= CFLAGS="${CFLAGS}" MAN1= lua-${LUA_VER}.1 luac-${LUA_VER}.1 DOCSDIR= ${PREFIX}/share/doc/${LUA_SUBDIR} --- lua-make-args-cflags.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: