From owner-svn-ports-all@FreeBSD.ORG Wed Nov 28 20:09:22 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 09F245E3; Wed, 28 Nov 2012 20:09:22 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [94.244.131.95]) by mx1.freebsd.org (Postfix) with ESMTP id B1A318FC12; Wed, 28 Nov 2012 20:09:21 +0000 (UTC) Date: Wed, 28 Nov 2012 22:09:20 +0200 From: Alex Kozlov To: Alexey Dokuchaev Subject: Re: svn commit: r307899 - head/benchmarks/super-smack Message-ID: <20121128200920.GA41552@ravenloft.kiev.ua> References: <201211281109.qASB9dPm010874@svn.freebsd.org> <20121128115359.GA53862@FreeBSD.org> <20121128130417.GA31569@ravenloft.kiev.ua> <20121128160825.GB53862@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121128160825.GB53862@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2012 20:09:22 -0000 On Wed, Nov 28, 2012 at 04:08:25PM +0000, Alexey Dokuchaev wrote: > On Wed, Nov 28, 2012 at 03:04:17PM +0200, Alex Kozlov wrote: > > On Wed, Nov 28, 2012 at 11:53:59AM +0000, Alexey Dokuchaev wrote: > > > On Wed, Nov 28, 2012 at 11:09:39AM +0000, Alex Kozlov wrote: > > > > New Revision: 307899 > > > > URL: http://svnweb.freebsd.org/changeset/ports/307899 > > > > > > > > +PGSQL_DESC= Enable PostgreSQL support > > > > +MYSQL_DESC= Enable MySQL support > > > > > > > In this case, generic descriptions should have been used. > > > > > No, specific descriptions are still better. > They are essentially the same modulo "enable" word, which was decided to > remove some time ago. In fact, "generic" descriptions are better since they > mention that is it *database* support. Doug removed the word "support" in > r305288, which many folks disagree with, but it will be backed out one we > will have dialog4ports committed, which will allow proper support for > checklists and radiobuttons. You can leave them now, but after r305288 will > be backed out, I will ask you again to drop them. Will do, my point was that 'MySQL support' is better than 'MySQL database'. > > This was impossible to catch in vim, it should be automated like with WWW. > > If this tag is obsolete, then portlint should display a warning. I can > > implement the patch, but before that can you please point me to documentation > > where it stated? Thanks. > It is not technically obsolete; sometimes it is the only attribution we > can provide. If there is actual WWW page, it should be dropped. It looks not hard to implement. Is it documented somewhere? Thanks for your reviews. -- Alex