From owner-cvs-ports@FreeBSD.ORG Sat May 22 12:07:13 2010 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A17A1106566B; Sat, 22 May 2010 12:07:13 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 2EBC18FC25; Sat, 22 May 2010 12:07:12 +0000 (UTC) X-Spam-Status: No X-Hellug-MailScanner-From: keramida@freebsd.org X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-0.981, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_40 -0.00, T_MIME_NO_TEXT 0.01, T_TVD_MIME_NO_HEADERS 0.01) X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-ID: o4MC6xvF030095 Received: from kobe.laptop (athedsl-419710.home.otenet.gr [79.131.191.124]) (authenticated bits=128) by igloo.linux.gr (8.14.3/8.14.3/Debian-9.1) with ESMTP id o4MC6xvF030095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 22 May 2010 15:07:05 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.4/8.14.4) with ESMTP id o4MC6wCm005015 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 22 May 2010 15:06:59 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.4/8.14.4/Submit) id o4MC6wx0005010; Sat, 22 May 2010 15:06:58 +0300 (EEST) (envelope-from keramida@freebsd.org) From: keramida@freebsd.org (Giorgos Keramidas) To: Hajimu UMEMOTO References: <201005211951.o4LJp46e084250@repoman.freebsd.org> <87bpc832m4.fsf@kobe.laptop> <20100522063751.GA87869@FreeBSD.org> <87y6fc1jxd.fsf@kobe.laptop> <20100522084946.GA23161@FreeBSD.org> Date: Sat, 22 May 2010 15:06:52 +0300 In-Reply-To: (Hajimu UMEMOTO's message of "Sat, 22 May 2010 19:16:22 +0900") Message-ID: <87ljbc16oz.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: cvs-ports@freebsd.org, Alexey Dokuchaev , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/editors/emacs Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2010 12:07:13 -0000 --=-=-= On Sat, 22 May 2010 19:16:22 +0900, Hajimu UMEMOTO wrote: > Hi, > >>>>>> On Sat, 22 May 2010 08:49:46 +0000 >>>>>> Alexey Dokuchaev said: > > danfe> Having `-nox11' suffixed ports nowadays (when we have OPTIONS framework > danfe> stable and mature enough) is mostly archaic, and can in fact be > danfe> confusing (like in this case). Previously, having the possibility to > danfe> build non-graphic version of their editor without having to explicitly > danfe> pass -DWITHOUT_X11 option was valued by some of us, but today preferred > danfe> OPTIONS are cached between updates in /var/db/ports/, so it's really the > danfe> same level of convenience without the need for slave port. Especially > danfe> when it does not play well with master. Suffixed slaves are almost > danfe> entirely limited to be useful only for non-OPTIONS ports these days. > > Yes, I think so, too. However, someone else want to have a slave port > for an OPTIONS port, in general. So, it is worth having a framework > for such needs, IMHO. > > danfe> One might argue that it's convenient to have -nox11 *package*, but in > danfe> this case special care must be taken (lurk for BATCH and > danfe> PACKAGE_BUILDING knobs in bpm). I would probably just went ahead and > danfe> killed `editors/emacs-nox11' port and be done with it, if anyone asks. > > Though I myself always build from ports and don't use packages, having > -nox11 package for emacs is good thing, IMHO. > I'm not sure how useful emacs with DBUS without X11 is. Actually, I'm > using emacs without both X11 and DBUS. How about disabling both, for > now? > > Index: emacs-nox11/Makefile > diff -u emacs-nox11/Makefile.orig emacs-nox11/Makefile > --- emacs-nox11/Makefile.orig 2010-05-22 16:49:34.528548000 +0900 > +++ emacs-nox11/Makefile 2010-05-22 19:09:24.284033237 +0900 > @@ -5,14 +5,12 @@ > # $FreeBSD: ports/editors/emacs-nox11/Makefile,v 1.3 2010/05/21 19:49:46 keramida Exp $ > # > > +BATCH= yes > +WITHOUT_DBUS= yes > WITHOUT_X11= yes > PKGNAMESUFFIX= -nox11 > > MASTERDIR= ${.CURDIR}/../emacs > LATEST_LINK= emacs-nox11 > > -#.if ${OSVERSION} < 700000 && defined(WITH_DBUS) > -#BROKEN= Does not currently build with dbus support > -#.endif > - > .include "${MASTERDIR}/Makefile" This looks nice. Let's pass it through the new maintainer of emacs* ports and commit it if Ashish does not object. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkv3yOEACgkQ1g+UGjGGA7bDFACfXkbr8FHz7jesrSgy2tenVgFI IukAn3uBUfQTq6HJXh9hT+uyXcgAw2NJ =vIzb -----END PGP SIGNATURE----- --=-=-=--