From owner-freebsd-java@FreeBSD.ORG Fri Jan 18 00:49:38 2008 Return-Path: Delivered-To: java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47A2216A421; Fri, 18 Jan 2008 00:49:38 +0000 (UTC) (envelope-from landonf@threerings.net) Received: from smtp.earth.threerings.net (smtp1.earth.threerings.net [64.127.109.108]) by mx1.freebsd.org (Postfix) with ESMTP id C660613C45A; Fri, 18 Jan 2008 00:49:37 +0000 (UTC) (envelope-from landonf@threerings.net) Received: from [192.168.54.11] (timor.sea.earth.threerings.net [192.168.54.11]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: landonf) by smtp.earth.threerings.net (Postfix) with ESMTP id 814A861E40; Thu, 17 Jan 2008 16:18:33 -0800 (PST) In-Reply-To: References: <200711301716.lAUHGEV1064334@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v753) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-95--1030004556" Message-Id: <90584F61-91FE-446E-978E-FD234553E8FC@threerings.net> From: Landon Fuller Date: Thu, 17 Jan 2008 16:18:14 -0800 To: "Arno J. Klaassen" , Daniel Eischen Content-Transfer-Encoding: 7bit X-Pgp-Agent: GPGMail 1.1.2 (Tiger) X-Mailer: Apple Mail (2.753) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: nate@yogotech.com, java@freebsd.org, ivo@scito.com, julian@freebsd.org, davidxu@freebsd.org Subject: Re: cvs commit: src/lib/libkse/thread thr_kern.c X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2008 00:49:38 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-95--1030004556 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed On Dec 2, 2007, at 09:31, Arno J. Klaassen wrote: > For info, the attached patch, which partially reverts mfc of rev 1.286 > of kern_fork.c, seems to work as well (without the above patch to > be clear), I just upgraded our 8-core build server from pre-november 6-STABLE to 6.3-RELEASE, and ran into this issue, causing our fork-heavy builder processes to lock up regularly. Your suggested patch (reverting the 1.286 MFC to sys/kern/ kern_fork.c) allows our builds to run to completion; I'll try digging into this further. Given how easy this is to reproduce, I'm hoping this is possible to fix before 6.3 is officially released? Here's a simple reproduction case that results in instant spinning sub-processes: #0 0x0000000800648b13 in mutex_lock_common (curthread=0x0, m=0x8007616e8, abstime=0x0) at /usr/src/lib/libpthread/thread/ thr_mutex.c:503 #1 0x000000080064ac25 in _pthread_mutex_lock (m=0x8007616e8) at /usr/ src/lib/libpthread/thread/thr_mutex.c:868 #2 0x000000080063e9ce in _spinlock (lck=0x8009ac200) at /usr/src/lib/ libpthread/thread/thr_spinlock.c:97 #3 0x00000008007eafc3 in pubrealloc (ptr=0x0, size=24, func=0x8008802b7 " in malloc():") at /usr/src/lib/libc/stdlib/ malloc.c:1090 #4 0x00000008007eb1e1 in malloc (size=24) at /usr/src/lib/libc/ stdlib/malloc.c:1150 #5 0x000000080065ab8c in _lockuser_init (lu=0x52e068, priv=0x52e000) at /usr/src/lib/libpthread/sys/lock.c:99 #6 0x000000080065ac69 in _lockuser_reinit (lu=0x52e068, priv=0x52e000) at /usr/src/lib/libpthread/sys/lock.c:128 #7 0x000000080064d6d0 in _kse_single_thread (curthread=0x50cc00) at / usr/src/lib/libpthread/thread/thr_kern.c:343 #8 0x000000080063b627 in _fork () at /usr/src/lib/libpthread/thread/ thr_fork.c:101 #9 0x00000000004008f1 in forker () #10 0x000000080064516e in thread_start (curthread=0x50cc00, start_routine=0x4008e0 , arg=0x0) at /usr/src/lib/libpthread/ thread/thr_create.c:341 #11 0x00000008007b3cd9 in makectx_wrapper (ucp=0x800530860, func=0x800645150 , args=0x7fffff7fcfd0) at /usr/src/lib/ libc/amd64/gen/makecontext.c:100 #12 0x0000000000000000 in ?? () #13 0x000000000050cc00 in ?? () #14 0x00000000004008e0 in frame_dummy () #include #include #include void *forker (void *arg) { while (1) { pid_t pid = fork(); if (pid == 0) { exit(0); } else if (pid > 0) { int status; waitpid(pid, &status, 0); } else { printf("Fork failed\n"); abort(); } } } int main(void) { int i = 0; for (i = 0; i < 4; i++) { pthread_t thr; pthread_create(&thr, NULL, forker, NULL); pthread_detach(thr); } while(1) sleep(1000); } --Apple-Mail-95--1030004556 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFHj/BGlplZCE/15mMRAkIJAJwORDIrtSz6ytnP5STB7bbpTqr79QCbBxvR hWbbpVd+1hyjvxeCoOY6FHQ= =uZXJ -----END PGP SIGNATURE----- --Apple-Mail-95--1030004556--