From owner-freebsd-hackers Mon Apr 1 19:54:33 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id B476637B416 for ; Mon, 1 Apr 2002 19:54:30 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id 81F2DAE0C7; Mon, 1 Apr 2002 19:54:30 -0800 (PST) Date: Mon, 1 Apr 2002 19:54:30 -0800 From: Alfred Perlstein To: Jon Ringuette Cc: freebsd-hackers@freebsd.org Subject: Re: Question about possibly additions to TOP Message-ID: <20020402035430.GE93885@elvis.mu.org> References: <3CA92355.8050001@imeme.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CA92355.8050001@imeme.net> User-Agent: Mutt/1.3.27i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Jon Ringuette [020401 19:20] wrote: > Sorry to bother everyone here but I have a quick question (or I guess > what I hope is a quick question). I have made some modifications to > src/usr.bin/machine.c to allow TOP to run in a jail (I have mostly just > taken out kvm_read's ) and zero'd out alot of information that is not > available to TOP in a jail ie . Total memory usage / swap usage / cpu > usage etc.. I would like to add an option -j to top and have it check > for that option to do this (sort of a really lightweight top if this > option is used). Would this be of interest to anymore for me to submit > a patch and if so how should I go about adding the -j option should I > make a copy of the top.c into src/usr.bin/top or contact the auther of > top to see about submitting it to him? I'm not sure if this would be > useful to anyone outside of the FreeBSD community is the reason I am a > bit iffy about doing that. If someone could point me in the right > direction to do this the correct way I would be very grateful, I really > want to code but I'm not sure where and how i should do it :) That would be pretty cool, why don't you use the gnats: http://www.freebsd.org/send-pr.html or just "send-pr" to submit your changes? One idea would be to fail gracefully, when unable to read kvm and such and keep the -j flag idea you had. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message