From owner-svn-src-all@freebsd.org Thu Jan 30 22:47:24 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B8267229F12; Thu, 30 Jan 2020 22:47:24 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from ecc05.stack.nl (ws0.zlo.nu [190.2.135.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.stack.nl", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487wTl1v9Kz3HYd; Thu, 30 Jan 2020 22:47:22 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mail03.stack.nl (blade.stack.nl [51.15.111.152]) by ecc05.stack.nl (Postfix) with ESMTPS id 9E352100267; Thu, 30 Jan 2020 23:47:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=stack.nl; s=mail; t=1580424435; bh=ggpGnMtQxZmZOowq7r37cVV7LNLjdfz6n2W4gppPzzU=; h=From:Subject:To:References:Date:In-Reply-To:From; b=RnJ8EUalXXTe23jYp/lvJIX1CeEPCX/0vwsT2OW3ZbZA41Ut1IKzaEtkObUOWOTH5 zYJi5SQsZue5qhumiibJ8AinGt2YiRFrFqcF2STvoJegMJhUPCfaSn8bYAKLExLzyi f98FQaJeH9N1Dt2p3GqJQzr7dF9hMu2U4UVv4rF621VBO4z3VS2X9sqXoNuGmQjAGF oYEKwarnl7PCnDefhs4ah/Ctf3/4kAbDAnnQkQyS9icrzIbpW8wXobOYavgsSpmpeD ZQNhXFNjoFOI4//TEEY6vcb43Rlf8A8cQyXrvW1F1pcSJg/Nw1bCpD4DiVPX6ZMcCA xFnvt2bNFq7NA== Received: from localhost (localhost.localdomain [127.0.0.1]) by mail03.stack.nl (Postfix) with ESMTP id 667D72E6; Thu, 30 Jan 2020 22:47:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail03.stack.nl Received: from mail03.stack.nl ([127.0.0.1]) by localhost (mail03.stack.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xUlQ-TWfczVO; Thu, 30 Jan 2020 22:47:12 +0000 (UTC) Received: from lion.tjoelker.org (unknown [193.84.188.49]) by mail03.stack.nl (Postfix) with ESMTPSA id AB06816C; Thu, 30 Jan 2020 22:47:12 +0000 (UTC) From: Jilles Tjoelker Subject: Re: svn commit: r357138 - head/bin/pwait To: Pawel Jakub Dawidek , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202001261049.00QAnORw063681@repo.freebsd.org> Message-ID: <6cb2e1c2-f81d-7e06-80a3-a0d7fee00c6a@stack.nl> Date: Thu, 30 Jan 2020 23:47:22 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <202001261049.00QAnORw063681@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 487wTl1v9Kz3HYd X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=stack.nl header.s=mail header.b=RnJ8EUal; dmarc=none; spf=pass (mx1.freebsd.org: domain of jilles@stack.nl designates 190.2.135.243 as permitted sender) smtp.mailfrom=jilles@stack.nl X-Spamd-Result: default: False [-3.17 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[stack.nl:s=mail]; RCVD_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:190.2.135.243]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[stack.nl]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.67)[ip: (-1.76), ipnet: 190.2.128.0/20(-0.88), asn: 49981(-0.73), country: NL(0.03)]; DKIM_TRACE(0.00)[stack.nl:+]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:49981, ipnet:190.2.128.0/20, country:NL]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 22:47:24 -0000 On 26-01-2020 11:49, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Sun Jan 26 10:49:24 2020 > New Revision: 357138 > URL: https://svnweb.freebsd.org/changeset/base/357138 > > Log: > - Be consistent with using sysexits(3) codes. > - Turn fprintf()+exit() into errx(). > > Sponsored by: Fudo Security > > Modified: > head/bin/pwait/pwait.c > > Modified: head/bin/pwait/pwait.c > ============================================================================== > --- head/bin/pwait/pwait.c Sun Jan 26 07:24:49 2020 (r357137) > +++ head/bin/pwait/pwait.c Sun Jan 26 10:49:24 2020 (r357138) > @@ -53,8 +53,7 @@ static void > usage(void) > { > > - fprintf(stderr, "usage: pwait [-t timeout] [-v] pid ...\n"); > - exit(EX_USAGE); > + errx(EX_USAGE, "usage: pwait [-t timeout] [-v] pid ..."); This adds a "pwait: " before the line, which most other programs do not do. -- Jilles Tjoelker