From owner-svn-src-all@freebsd.org Wed Jun 13 11:43:48 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99B8E1000F39; Wed, 13 Jun 2018 11:43:48 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B66A97CEA9; Wed, 13 Jun 2018 11:43:47 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id cdfdc417; Wed, 13 Jun 2018 13:43:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h= mime-version:content-type:content-transfer-encoding:date:from:to :cc:subject:in-reply-to:references:message-id; s=mail; bh=tHW+4m YewQn2nQlxxGcVQyGN4qw=; b=hOIvNCh6lICN68BtJX9K72l/jKEuZJAfmncBBr N8ulLtQZWGtj2unIGhhuVMdbmLwBrGP7FMT3gdnZ73Kd3j5RWjCHhfyQJJ8KNMIo bmKhoLDpXfRZLA15QXLgJSPo32CZr1EOcGbAJLfKySIrPruPhlpebC+/lfSm7x4g XyYFY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h= mime-version:content-type:content-transfer-encoding:date:from:to :cc:subject:in-reply-to:references:message-id; q=dns; s=mail; b= eTKmgxAGOZVJbqE/jnhtd8molSk5X6SqmX7o5+k9RGLr9dEbfD14/5k8lJQ7JpFR cwQOxBRuy8n/oj6P0DmOD23ssl/F51ZAJcK+cZQdRhbeD9OWWW0ojqtGgvd47H2V fG8UGW+PI4YGoqzzJjZHCMFvAmI2AuMUSUPXEPOPmuY= Received: from webmail.megadrive.org (www1.blih.net [212.83.177.180]) by mail.blih.net (OpenSMTPD) with ESMTP id 3a00b1de; Wed, 13 Jun 2018 13:43:44 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 13 Jun 2018 13:43:44 +0200 From: Emmanuel Vadot To: Edward Tomasz Napierala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, owner-src-committers@freebsd.org Subject: Re: svn commit: r335004 - head/release/tools Organization: Bidouilliste In-Reply-To: <201806121645.w5CGjrMM099365@repo.freebsd.org> References: <201806121645.w5CGjrMM099365@repo.freebsd.org> Message-ID: <941a15be461602ae3d723c3f30804248@megadrive.org> X-Sender: manu@bidouilliste.com User-Agent: Roundcube Webmail/1.1.1 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 11:43:48 -0000 On 2018-06-12 18:45, Edward Tomasz Napierala wrote: > Author: trasz > Date: Tue Jun 12 16:45:52 2018 > New Revision: 335004 > URL: https://svnweb.freebsd.org/changeset/base/335004 > > Log: > Enable USB OTG serial terminal on ARM SD card images. This > configures > the system to make use of USB device mode / USB OTG to provide a > "virtual > serial port" on release images. > > Reviewed by: gjb@ > MFC after: 2 weeks > Relnotes: yes > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D15602 > > Modified: > head/release/tools/arm.subr > > Modified: head/release/tools/arm.subr > ============================================================================== > --- head/release/tools/arm.subr Tue Jun 12 16:44:13 2018 (r335003) > +++ head/release/tools/arm.subr Tue Jun 12 16:45:52 2018 (r335004) > @@ -92,6 +92,41 @@ arm_create_user() { > return 0 > } > > +arm_setup_usb_otg() { > + # Set up virtual serial port over USB OTG / device mode. > + echo >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo '# Required for USB OTG virtual serial port.' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo 'notify 100 {' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo ' match "system" "DEVFS";' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo ' match "subsystem" "CDEV";' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo ' match "type" "CREATE";' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo ' match "cdev" "ttyU[0-9]+";' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo ' action "/sbin/init q";' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf > + echo '};' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/devd.conf This will be wiped after the first update, better create /etc/devd/otg_serial.conf > + echo '# USB OTG virtual serial port' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/ttys > + echo 'ttyU0 "/usr/libexec/getty 3wire" vt100 onifconsole secure' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/ttys > + echo 'ttyU1 "/usr/libexec/getty 3wire" vt100 onifconsole secure' \ > + >> ${CHROOTDIR}/${DESTDIR}/etc/ttys If I have no OTG port and a usb<->uart plugged into my board that will give weird result no ? > + echo '# Configure USB OTG; see usb_template(4).' \ > + >> ${CHROOTDIR}/${DESTDIR}/boot/loader.conf > + echo 'hw.usb.template=3' \ > + >> ${CHROOTDIR}/${DESTDIR}/boot/loader.conf > + echo 'umodem_load="YES"' \ > + >> ${CHROOTDIR}/${DESTDIR}/boot/loader.conf I'm not a big fan of always enabling this functionality. Do you have a board that have no uart but an otg port ? > +} > + > arm_install_base() { > chroot ${CHROOTDIR} mount /dev/${mddev}s2a ${DESTDIR} > eval chroot ${CHROOTDIR} make -C ${WORLDDIR} \ > @@ -102,6 +137,7 @@ arm_install_base() { > chroot ${CHROOTDIR} mkdir -p ${DESTDIR}/boot/msdos > > arm_create_user > + arm_setup_usb_otg > > echo '# Custom /etc/fstab for FreeBSD embedded images' \ > > ${CHROOTDIR}/${DESTDIR}/etc/fstab -- Emmanuel Vadot