From owner-svn-src-all@freebsd.org Thu Jan 17 19:14:04 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CAA914A1E1A; Thu, 17 Jan 2019 19:14:04 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D8BA776984; Thu, 17 Jan 2019 19:14:02 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id x0HJMYaq029738; Thu, 17 Jan 2019 11:22:34 -0800 (PST) (envelope-from mckusick@mckusick.com) Message-Id: <201901171922.x0HJMYaq029738@chez.mckusick.com> From: Kirk McKusick To: Andriy Gapon Subject: Re: svn commit: r343113 - head/contrib/libc++/include cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick In-reply-to: <99fd64c3-b3b3-fd50-6370-224a329a3340@FreeBSD.org> Comments: In-reply-to Andriy Gapon message dated "Thu, 17 Jan 2019 19:05:20 +0200." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29736.1547752954.1@chez.mckusick.com> Date: Thu, 17 Jan 2019 11:22:34 -0800 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: D8BA776984 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.945,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 19:14:04 -0000 > From: Andriy Gapon > Date: Thu, 17 Jan 2019 19:05:20 +0200 > To: Kirk McKusick , src-committers@freebsd.org, > svn-src-all@freebsd.org, svn-src-head@freebsd.org > Subject: Re: svn commit: r343113 - head/contrib/libc++/include > > On 17/01/2019 17:35, Kirk McKusick wrote: >> -#ifdef ELAST >> +#if defined(ELAST) > > I think that these are exactly the same, so not sure what the change does. > > -- > Andriy Gapon It was suggested to me that Clang was 'strict' and that it would kick out the first form. That proved to not be true. To compound my goof, I missed the actual fix when I did the commit, so had to do -r343115 to get the needed part of the fix in place. I should learn to have my morning coffee *before* commiting anything. Kirk McKusick