Date: Wed, 15 Apr 2015 06:41:52 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Mikhail Teterin <mi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r384031 - in head/net/libsrtp: . files Message-ID: <a8ya-2eb3-wny@FreeBSD.org> In-Reply-To: <oamq-2eno-wny@FreeBSD.org> (Jan Beich's message of "Wed, 15 Apr 2015 06:34:19 %2B0200") References: <201504142224.t3EMOiuf041928@svn.freebsd.org> <oamq-2eno-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Jan Beich <jbeich@FreeBSD.org> writes:
>> Implement regression-check target (also known under other aliases)
>> using upstream's self-tests.
> [...]
>> post-build:
>> @(cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} ${MAKE_FLAGS} \
>> ${MAKEFILE} ${MAKE_ARGS} shared_library)
>>=20=20
>> +check test runtest regression-test: build
>> + ${SETENV} LD_LIBRARY_PATH=3D${WRKSRC} ${MAKE_CMD} -C ${WRKSRC} runtest
>> +
>
> Maybe convert to DO_MAKE_BUILD ? shared_library ignores MAKE_JOBS_NUMBER
> while runtest ignores MAKE_ENV (mainly HOME=3D${WRKDIR}).
>
> post-build:
> @(cd ${WRKSRC} && ${DO_MAKE_BUILD} shared_library)
>
> check test runtest regression-test: build
> @(cd ${WRKSRC} && ${SETENV} LD_LIBRARY_PATH=3D${WRKSRC} \
> ${DO_MAKE_BUILD} runtest)
Here's a patch. post-build is also almost identical to do-build,
so can be converted to ALL_TARGET+=3Dshared_library.
Index: net/libsrtp/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- net/libsrtp/Makefile (revision 384037)
+++ net/libsrtp/Makefile (working copy)
@@ -20,6 +20,7 @@ GNU_CONFIGURE=3D yes
CONFIGURE_ARGS=3D --enable-openssl
CPPFLAGS+=3D -I${OPENSSLBASE}/include
LIBS+=3D -L${OPENSSLBASE}/lib
+ALL_TARGET=3D all shared_library
USES=3D gmake pathfix pkgconfig
USE_LDCONFIG=3D yes
USE_OPENSSL=3D yes
@@ -37,11 +38,8 @@ WITH_OPENSSL_PORT=3D yes
post-patch:
@${REINPLACE_CMD} '/pkg-config.*openssl/d' ${WRKSRC}/configure
=20
=2Dpost-build:
=2D @(cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} ${MAKE_FLAGS} \
=2D ${MAKEFILE} ${MAKE_ARGS} shared_library)
=2D
check test runtest regression-test: build
=2D ${SETENV} LD_LIBRARY_PATH=3D${WRKSRC} ${MAKE_CMD} -C ${WRKSRC} runtest
+ @(cd ${WRKSRC} && ${SETENV} LD_LIBRARY_PATH=3D${WRKSRC} \
+ ${DO_MAKE_BUILD} runtest)
=20
.include <bsd.port.mk>
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJVLewQXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b2bgIALb5LP0PkV+quxbdxPdz9Ykc
4dVt9A4eUJ6av16eR7VBLyZb96Xy4mJBVP5ejMPWVi/HZ8ZW4YwGzYK5M4tX3Iu0
EHfJTl8FNej2jmKMVcncdlNPhd5xeXTPZUXPH6d77d1nHQTkR3mltvxYZSi979+l
AJ77HGf+xezQJZmd4Y5004tT9p0w22NeeQwBbiRV5SPIP6Q/qidL78M10bNQ3pm1
+YOxQ8ZJWGJUueLN6x9Rg4jeyX/7fEcqgkW5W5MqF6mNY/1d1wwEIoIDdgzdYiQ2
37JIjI3IEmG8nSZt5foCSooOxYYo4NSSltUgLc7iqM+7FPoIWRTTR9q1v2cAuGU=
=gbWH
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a8ya-2eb3-wny>