From owner-cvs-all Mon Mar 17 9: 4:18 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD3CD37B401; Mon, 17 Mar 2003 09:04:15 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D1B643F3F; Mon, 17 Mar 2003 09:04:14 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.8/8.12.8) with ESMTP id h2HH4CYl012558; Mon, 17 Mar 2003 18:04:13 +0100 (CET) (envelope-from phk@phk.freebsd.dk) To: obrien@FreeBSD.org Cc: "Andrey A. Chernov" , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/awk Makefile From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 17 Mar 2003 09:00:03 PST." <20030317170003.GA31982@dragon.nuxi.com> Date: Mon, 17 Mar 2003 18:04:12 +0100 Message-ID: <12557.1047920652@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20030317170003.GA31982@dragon.nuxi.com>, "David O'Brien" writes: >On Mon, Mar 17, 2003 at 11:46:36AM +0300, Andrey A. Chernov wrote: >> On Mon, Mar 17, 2003 at 00:07:54 -0800, David E. O'Brien wrote: >> > obrien 2003/03/17 00:07:54 PST >> > >> > FreeBSD src repository >> > >> > Modified files: >> > usr.bin/awk Makefile >> > Log: >> > For the bwk_20030314 version, we have to -DHAS_ISBLANK now. >> > Oh how I wish the author had accepted my "#ifndef isblank" patch instead. >> >> In strict sense isblank() is a function, not necessary a macro. > >Show me a single real implimentation that isn't a macro. Cut from an odd-ball embedded environment which cares very much about not inlining things with macros: #ifdef TINY_MODE [...] static inline int isblank(int c) { return(__ISBLANK(c)); } [...] #else [...] #define isblank(c) __ISBLANK(c) [...] #endif -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message