From owner-svn-src-all@FreeBSD.ORG Thu Jan 29 17:37:01 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D3BC779F; Thu, 29 Jan 2015 17:37:01 +0000 (UTC) Received: from mail-lb0-x229.google.com (mail-lb0-x229.google.com [IPv6:2a00:1450:4010:c04::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5E506C59; Thu, 29 Jan 2015 17:37:01 +0000 (UTC) Received: by mail-lb0-f169.google.com with SMTP id f15so30729830lbj.0; Thu, 29 Jan 2015 09:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=d5/+dQr2L49FT53pHN5sETTh0lnfanX+DEJe0RuH3TA=; b=uVlhS1cvfdHx6bNCue+oOsrXDKywp/KZdozgMLL8J2lPrfCfy3Q9WcogGo8e5EyT7i CNxbLNN6n0+G+bQtENlMjkadI+lXtBQEn0jIGAt2pXMXO95dgQpayNdtS/rvNT7Y4eYq OleYfZthrb51QXHDYxtP+SYH7jtxKz9NVMeKmSRWNIwkK6+Tl7a5EP9XXvpETpe2WljU JSD5rtE3N6LNDGPPWY7mZFNF7q+epqGWejC3tNff7bhY4k0XAn0pZ+02fJljIcTqoMZT Teu0Pt1mvNAJwUqXvtOZvmD9Uk651FF14Kmafx60cXJCfdtvhqBSVekq15VACN3rBLvb ZwNw== MIME-Version: 1.0 X-Received: by 10.112.61.228 with SMTP id t4mr2409287lbr.0.1422553018658; Thu, 29 Jan 2015 09:36:58 -0800 (PST) Sender: davide.italiano@gmail.com Received: by 10.25.155.4 with HTTP; Thu, 29 Jan 2015 09:36:58 -0800 (PST) In-Reply-To: <201501291530.t0TFU5Qb077741@svn.freebsd.org> References: <201501291530.t0TFU5Qb077741@svn.freebsd.org> Date: Thu, 29 Jan 2015 09:36:58 -0800 X-Google-Sender-Auth: vl6w9igQ3ATjLfMqNIMXwnzlI_s Message-ID: Subject: Re: svn commit: r277877 - head/lib/libc/mips/gen From: Davide Italiano To: Ed Maste Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 17:37:01 -0000 On Thu, Jan 29, 2015 at 7:30 AM, Ed Maste wrote: > Author: emaste > Date: Thu Jan 29 15:30:04 2015 > New Revision: 277877 > URL: https://svnweb.freebsd.org/changeset/base/277877 > > Log: > Use zero register instead of immediate 0x0 in MIPS assembly > > It seems GAS makes the substitution automatically, but Clang's > integrated assembler does not (yet). It fails with "invalid operand for > instruction." > > Reported by: sbruno > > Modified: > head/lib/libc/mips/gen/sigsetjmp.S > > Modified: head/lib/libc/mips/gen/sigsetjmp.S > ============================================================================== > --- head/lib/libc/mips/gen/sigsetjmp.S Thu Jan 29 14:23:31 2015 (r277876) > +++ head/lib/libc/mips/gen/sigsetjmp.S Thu Jan 29 15:30:04 2015 (r277877) > @@ -61,7 +61,7 @@ __FBSDID("$FreeBSD$"); > LEAF(sigsetjmp) > PIC_PROLOGUE(sigsetjmp) > > - bne a1, 0x0, 1f # do saving of signal mask? > + bne a1, zero, 1f # do saving of signal mask? > PIC_TAILCALL(_setjmp) > > 1: PIC_TAILCALL(setjmp) > Ed, did you open a bug for this on LLVM bugzilla? If yes, can you please link it here, for the records? -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare