From owner-svn-src-user@freebsd.org Thu Jan 4 13:47:02 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 408F0EB5699 for ; Thu, 4 Jan 2018 13:47:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 190086A1DD; Thu, 4 Jan 2018 13:46:58 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w04DktVk001404; Thu, 4 Jan 2018 05:46:55 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w04DkroU001403; Thu, 4 Jan 2018 05:46:53 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201801041346.w04DkroU001403@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r327534 - in user/jeff/numa/sys: arm/arm ddb kern netpfil/ipfw sys In-Reply-To: <201801040002.w0402lSJ045718@repo.freebsd.org> To: Jeff Roberson Date: Thu, 4 Jan 2018 05:46:53 -0800 (PST) CC: src-committers@freebsd.org, svn-src-user@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2018 13:47:02 -0000 > Author: jeff > Date: Thu Jan 4 00:02:47 2018 > New Revision: 327534 > URL: https://svnweb.freebsd.org/changeset/base/327534 > > Log: > The inclusion of _vm_domain.h in proc.h created pollution from seq.h that > many files now rely on. Fix a small number of these to remove seq.h, lock.h, > and _vm_domain.h. Explicitly add systm.h, types.h and machine/cpu.h so the > rest still compiles and the pollution is direct. Wouldnt it be best to fix this in HEAD rather than have this come in as part of your NUMA changes? This is a generic issue, un related to the numa stuff. Just a thought, I know it is a merge conflict with your branch, but it also reduces the diff from your branch current. > > Modified: > user/jeff/numa/sys/arm/arm/machdep_ptrace.c > user/jeff/numa/sys/ddb/db_run.c > user/jeff/numa/sys/kern/subr_kdb.c > user/jeff/numa/sys/netpfil/ipfw/dn_sched_fq_codel.c > user/jeff/numa/sys/sys/proc.h > > Modified: user/jeff/numa/sys/arm/arm/machdep_ptrace.c > ============================================================================== > --- user/jeff/numa/sys/arm/arm/machdep_ptrace.c Wed Jan 3 23:59:29 2018 (r327533) > +++ user/jeff/numa/sys/arm/arm/machdep_ptrace.c Thu Jan 4 00:02:47 2018 (r327534) > @@ -32,6 +32,7 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > #include > > #include > > Modified: user/jeff/numa/sys/ddb/db_run.c > ============================================================================== > --- user/jeff/numa/sys/ddb/db_run.c Wed Jan 3 23:59:29 2018 (r327533) > +++ user/jeff/numa/sys/ddb/db_run.c Thu Jan 4 00:02:47 2018 (r327534) > @@ -40,6 +40,7 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > > #include > #include > > Modified: user/jeff/numa/sys/kern/subr_kdb.c > ============================================================================== > --- user/jeff/numa/sys/kern/subr_kdb.c Wed Jan 3 23:59:29 2018 (r327533) > +++ user/jeff/numa/sys/kern/subr_kdb.c Thu Jan 4 00:02:47 2018 (r327534) > @@ -38,6 +38,7 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > #include > #include > #include > > Modified: user/jeff/numa/sys/netpfil/ipfw/dn_sched_fq_codel.c > ============================================================================== > --- user/jeff/numa/sys/netpfil/ipfw/dn_sched_fq_codel.c Wed Jan 3 23:59:29 2018 (r327533) > +++ user/jeff/numa/sys/netpfil/ipfw/dn_sched_fq_codel.c Thu Jan 4 00:02:47 2018 (r327534) > @@ -44,6 +44,7 @@ > #include /* flow_id */ > #include > > +#include > #include > #include > > > Modified: user/jeff/numa/sys/sys/proc.h > ============================================================================== > --- user/jeff/numa/sys/sys/proc.h Wed Jan 3 23:59:29 2018 (r327533) > +++ user/jeff/numa/sys/sys/proc.h Thu Jan 4 00:02:47 2018 (r327534) > @@ -62,12 +62,17 @@ > #include /* For structs itimerval, timeval. */ > #else > #include > +#include > #endif > #include > #include > -#include > +#include > #include > + > #include /* Machine-dependent proc substruct. */ > +#ifdef _KERNEL > +#include > +#endif > > > /* > @@ -181,6 +186,7 @@ struct procdesc; > struct racct; > struct sbuf; > struct sleepqueue; > +struct socket; > struct syscall_args; > struct td_sched; > struct thread; > > -- Rod Grimes rgrimes@freebsd.org