From owner-svn-src-head@freebsd.org  Tue Aug 21 23:00:24 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D327310820AE;
 Tue, 21 Aug 2018 23:00:23 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 86BAC7270B;
 Tue, 21 Aug 2018 23:00:23 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from mail-io0-f177.google.com (mail-io0-f177.google.com
 [209.85.223.177])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G3" (verified OK))
 (Authenticated sender: mmacy)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 4C6C0EF74;
 Tue, 21 Aug 2018 23:00:23 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: by mail-io0-f177.google.com with SMTP id v14-v6so30261iob.4;
 Tue, 21 Aug 2018 16:00:23 -0700 (PDT)
X-Gm-Message-State: APzg51CZwxFsJ6q/YowkSzQAUGS4bmdZe2BcWbyckInHZFT/sOGkHZTD
 AA6fqYrHvMlOQ6x8MGfXMZOMII1O8XD/4Ozz2kw=
X-Google-Smtp-Source: ANB0Vda8Zh46XnZhP92Dqv8NCwhI2uwKa5lr4uNoKqjCqZ7g/Iu45deP82d1Gh75dhXtjmtt6aF3Z556ofRPiza3i7U=
X-Received: by 2002:a5e:dd4b:: with SMTP id
 u11-v6mr3260445iop.237.1534892422746; 
 Tue, 21 Aug 2018 16:00:22 -0700 (PDT)
MIME-Version: 1.0
References: <201808152023.w7FKN9LL055254@repo.freebsd.org>
 <20180821212047.GM27633@FreeBSD.org>
In-Reply-To: <20180821212047.GM27633@FreeBSD.org>
From: Matthew Macy <mmacy@freebsd.org>
Date: Tue, 21 Aug 2018 16:00:10 -0700
X-Gmail-Original-Message-ID: <CAPrugNr6N8O+VA5Nykh58aV733_5aj4vbgh=S-6A3Awf+K_zDw@mail.gmail.com>
Message-ID: <CAPrugNr6N8O+VA5Nykh58aV733_5aj4vbgh=S-6A3Awf+K_zDw@mail.gmail.com>
Subject: Re: svn commit: r337866 - in head/sys: net netinet netinet6
To: Gleb Smirnoff <glebius@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.27
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Aug 2018 23:00:24 -0000

Yes. See r338162. Thanks.
-M

On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff <glebius@freebsd.org> wrote:

> On Wed, Aug 15, 2018 at 08:23:09PM +0000, Matt Macy wrote:
> M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct
> ifmultiad
> M>                      ll_ifma->ifma_ifp = NULL;       /* XXX */
> M>              if (--ll_ifma->ifma_refcount == 0) {
> M>                      if (ifp != NULL) {
> M> -                            CK_STAILQ_REMOVE(&ifp->if_multiaddrs,
> ll_ifma, ifmultiaddr,
> M> -                                ifma_link);
> M> +                            if (ll_ifma->ifma_flags & IFMA_F_ENQUEUED)
> {
> M> +
> CK_STAILQ_REMOVE(&ifp->if_multiaddrs, ll_ifma, ifmultiaddr,
> M> +                                            ifma_link);
> M> +                                    ifma->ifma_flags &=
> ~IFMA_F_ENQUEUED;
> M> +                            }
> M>                      }
> M>                      if_freemulti(ll_ifma);
> M>              }
>
> Coverity suggested there is a cut and paste mistake here, and it is
> compilable.
> After quick glance I tend to agree. Looks like flag is cleared on wrong
> ifma.
>
> --
> Gleb Smirnoff
>