From owner-svn-src-head@freebsd.org Fri Nov 17 18:37:54 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84BE1DE0991; Fri, 17 Nov 2017 18:37:54 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-qt0-x22f.google.com (mail-qt0-x22f.google.com [IPv6:2607:f8b0:400d:c0d::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 461F270B8C; Fri, 17 Nov 2017 18:37:54 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-qt0-x22f.google.com with SMTP id f8so7977070qta.5; Fri, 17 Nov 2017 10:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sYXfscAlf31xF8UrhF49JcHKkxb0mzTYwZxBslqOS1E=; b=uLROO2JRIbzFQJQDAq0B4vgVFb5tlen5pZi+tMyoe3J683W6CsGq9O3vhzJQ91/BIC 9bd543czJUyLLRE5RXuJfajTbKbI2heudQRIJPnKlBFctWqDqtr7SyfUs8VI0uZvF045 g7mNE4r5Qfm0jRKaJt28WeekBr+cRtFAtCw+zZOZiAZEDXXIn6CkiFmYpVST21dBD6g7 aOkOeAk+lLoafr6PI2teF1jNd66FUMJz1o4J9JMaOKyYQ+W0orBukuW80JcHMsritbGb 44A7EWkAz2CCW+jgsPjqju80rZ24FUABw0UuABJN8+aOQ629AplEFi8h/7B1Q/krMuT+ pUkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sYXfscAlf31xF8UrhF49JcHKkxb0mzTYwZxBslqOS1E=; b=dkkL+KxEiAukzcETEC3TURcvr3LV+ic8qfdVgpDAKPbYRTbF5sqSYD2uhbLQaXOU6H OX+T9Krwv+WpCuiuN4deey/zgl1GnDB68gw8kihutXovB5ySpNhLQrGkrl0a7Unza7FG DL2yGLy2DDWDTvyqeaOgofMrvQUsCdw7JLCTQ+4kugv9H4uc0sbBHDMJkiOqa9k6D6F6 MjjTdY2iCXfhez+MSWt1CPa8GKjNeaB2S0ca4dCJPqN0wVpiglV1SQZ90g1DtzukRKvf 4s+FHgNCBiR6hv86YqOIjtZ0j5nVhK8v/bU2S/TYU74dfxjKFjfWv73ahn8FyS1PICjY 25jw== X-Gm-Message-State: AJaThX49JgfdjvnVWfsrvhWsG8jZ514bcMQ13WUWh0de8gvSzRgnXjIx TRn6d893jaPIH8FE3/VsIwdDoFojhiPo9cPlcgs= X-Google-Smtp-Source: AGs4zMb+LRXxqfSFvqbwWzG6gIzP2sWC/joSbeiXbIgoU5vSiq0Osme/GKHEKixnC5RruVpSBI5B3VGQ+AMv/Uusa2Q= X-Received: by 10.200.10.75 with SMTP id f11mr9310417qti.272.1510943873063; Fri, 17 Nov 2017 10:37:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.39.211 with HTTP; Fri, 17 Nov 2017 10:37:52 -0800 (PST) In-Reply-To: <201707251438.v6PEcUAC026283@repo.freebsd.org> References: <201707251438.v6PEcUAC026283@repo.freebsd.org> From: Ryan Stone Date: Fri, 17 Nov 2017 13:37:52 -0500 Message-ID: Subject: Re: svn commit: r321476 - head/sys/dev/ixgbe To: Sean Bruno Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 18:37:54 -0000 On Tue, Jul 25, 2017 at 10:38 AM, Sean Bruno wrote: > Author: sbruno > Date: Tue Jul 25 14:38:30 2017 > New Revision: 321476 > URL: https://svnweb.freebsd.org/changeset/base/321476 > > Log: > Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm" > of LOR detection and a bit of lock release/acquire collision when using LRO. Without the lock held how do we guarantee that multiple threads can't be processing LRO at the same time?