From owner-freebsd-ports-bugs@freebsd.org  Tue Nov  1 20:16:26 2016
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 22AE2C2AF36
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Tue,  1 Nov 2016 20:16:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E2A191211
 for <freebsd-ports-bugs@FreeBSD.org>; Tue,  1 Nov 2016 20:16:25 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uA1KGPAg049746
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 1 Nov 2016 20:16:25 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 213985] science/avogadro: fix for lang/gcc5
Date: Tue, 01 Nov 2016 20:16:26 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: gerald@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-213985-13-3VS0I7jaFx@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-213985-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-213985-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Nov 2016 20:16:26 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213985

--- Comment #1 from Gerald Pfeifer <gerald@FreeBSD.org> ---
Thanks for looking into this, Kenneth!

I am not familiar with this port, nor even Eigen, so I hope some other
committer will grab this, but one comment/suggestion on this patch:

++// fix for lang/gcc5
++#if __GNUC__ =3D=3D 5 && __GNUC_MINOR__ =3D=3D 4
++#undef minor
++#endif

Why check for __GNUC_MINOR__, especially with =3D=3D?  What if the lang/gcc5
port is updated to version 5.5?

Wouldn't it be best to just check for __GNUC__, ignoring __GNUC_MINOR__,
and perhaps even __GNUC__ >=3D 5?

--=20
You are receiving this mail because:
You are the assignee for the bug.=