From owner-svn-src-all@freebsd.org  Thu Jan 10 07:38:36 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E78A114A24CF;
 Thu, 10 Jan 2019 07:38:35 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [198.45.61.253])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7AF9D6EA62;
 Thu, 10 Jan 2019 07:38:35 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x0A7cRwv017195
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Wed, 9 Jan 2019 23:38:28 -0800 (PST)
 (envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id x0A7cRER017194;
 Wed, 9 Jan 2019 23:38:27 -0800 (PST)
 (envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@freebsd.org using -f
Date: Wed, 9 Jan 2019 23:38:27 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: "Andrey V. Elsukov" <ae@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r342908 - head/sys/netpfil/ipfw
Message-ID: <20190110073827.GE18452@FreeBSD.org>
References: <201901100147.x0A1lvQX035635@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201901100147.x0A1lvQX035635@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 7AF9D6EA62
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.98 / 15.00]; REPLY(-4.00)[];
 NEURAL_HAM_SHORT(-0.98)[-0.985,0];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 07:38:36 -0000

On Thu, Jan 10, 2019 at 01:47:57AM +0000, Andrey V. Elsukov wrote:
A>   glebius@ has reported that they at Netflix discovered, that initialization
A>   of this variable produces significant overhead on packet processing.
A>   After patching I managed to increase performance of packet processing on
A>   simple routing with ipfw(4) firewalling to about 11% from 9.8Mpps up to
A>   11Mpps (Xeon E5-2660 v4@ + Mellanox 100G card).

And with ipfw being processed at driver level, rather than ip_input()
the boost is even more dramatic than 11%.

https://github.com/glebius/FreeBSD/commits/pfil

Soon to reach FreeBSD head :)

-- 
Gleb Smirnoff