From owner-freebsd-alpha  Mon Jul  5 16:51:47 1999
Delivered-To: freebsd-alpha@freebsd.org
Received: from bubba.whistle.com (s205m7.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP
	id C3FEC14BCD; Mon,  5 Jul 1999 16:51:44 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.2/8.9.2) id QAA27061;
	Mon, 5 Jul 1999 16:51:43 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199907052351.QAA27061@bubba.whistle.com>
Subject: Re: alpha kernel build failure (w/patch)
In-Reply-To: <Pine.OSF.4.10.9907050031040.19262-100000@fly.HiWAAY.net> from Steve Price at "Jul 5, 99 00:33:57 am"
To: sprice@hiwaay.net (Steve Price)
Date: Mon, 5 Jul 1999 16:51:43 -0700 (PDT)
Cc: freebsd-alpha@FreeBSD.ORG, freebsd-current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL38 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-alpha@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Steve Price writes:
>  	}
> +#ifdef __i386__
>  	sc->wb_btag = I386_BUS_SPACE_IO;
> +#endif
> +#ifdef __alpha__
> +	sc->wb_btag = ALPHA_BUS_SPACE_IO;
> +#endif
>  #else
>  	if (!(command & PCIM_CMD_MEMEN)) {

Just a minor comment.. anytime you have something like this, it's
always nice to do it this way instead:

  #if defined(__i386__)
	  sc->wb_btag = I386_BUS_SPACE_IO;
  #elif defined(__alpha__)
	  sc->wb_btag = ALPHA_BUS_SPACE_IO;
  #else
  #error Machine architecture unsupported
  #endif

That way when somebody wants to add M68K support or whatever they
are alerted that they need to implement the new flag at compile
time instead of at panic time :-)

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message