From owner-freebsd-ports@FreeBSD.ORG Mon May 28 06:16:37 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B151D1065672; Mon, 28 May 2012 06:16:37 +0000 (UTC) (envelope-from rsimmons0@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4B5A78FC0C; Mon, 28 May 2012 06:16:37 +0000 (UTC) Received: by vbmv11 with SMTP id v11so2165150vbm.13 for ; Sun, 27 May 2012 23:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=nG26dzFiVz2BzrFzPCZ0KbZ/p8VqPzH5OPc6zo/9X/o=; b=QXj9lGwnjRK4XUKWs5HvAxVABwVQqdQHzYEw8UbJZhUuJ0ebkeks0UBhWObr+6vw3q JwVYkNiHrOEjsntE20521R28vm7gYXEXfvZ2LGbwk/1fN2djZ/utZz+3B6j1/vvD8vk3 E3DuKgo5wWnwoABacVaJs5s2x+kbFMuC/M5r5lUISUH3jQp6zDWQSOOxf1IyvYoa8fYN gdrNLf4Cle6qFcb9PF4SnMtDL+2v/URF1UIYSIpehlUekgbCdOl1y5jjrXX2lv5e7Myy Sut4SV0TJ0AGPTXOTkOGXNqGC85PtNK9ML7XldxH77S59LuUbAI/XYTUD0a8GLnMPwDF gaLQ== MIME-Version: 1.0 Received: by 10.52.69.110 with SMTP id d14mr6162824vdu.124.1338185796678; Sun, 27 May 2012 23:16:36 -0700 (PDT) Received: by 10.52.113.97 with HTTP; Sun, 27 May 2012 23:16:36 -0700 (PDT) In-Reply-To: <20120527193309.GC38274@atarininja.org> References: <20120527193309.GC38274@atarininja.org> Date: Mon, 28 May 2012 02:16:36 -0400 Message-ID: From: Robert Simmons To: Wesley Shields Content-Type: multipart/mixed; boundary=20cf307f323a0df45c04c112a92c Cc: joerg.pulz@frm2.tum.de, freebsd-ports@freebsd.org Subject: Re: More Heimdal 1.5.2 port problems X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2012 06:16:37 -0000 --20cf307f323a0df45c04c112a92c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, May 27, 2012 at 3:33 PM, Wesley Shields wrote: > On Sun, May 27, 2012 at 01:58:23PM -0400, Robert Simmons wrote: >> On Sat, May 26, 2012 at 3:22 PM, Robert Simmons wr= ote: >> > I've found another problem with the port. >> > >> > kadmind and kdc both look for krb5.conf in /usr/local/etc, but >> > kpasswdd and kstash look for it in /etc. ?This can be fixed with a >> > symlink, but I feel like that's not the best solution. ?Ultimately, >> > all the heimdal utilities and daemons should be looking in the same >> > location for krb5.conf, correct? >> > >> > I don't see any flags for kstash or kpasswdd to change where they look >> > for krb5.conf. >> > >> > I'm going to go back and compile it from source again and see if there >> > is another configure flag that is missing from the port. >> >> I've attached a patch for this problem. =A0Please review it and make >> sure this is the right way to fix the problem. > >> --- Makefile.old =A0 =A0 =A02012-05-27 13:53:01.132516965 -0400 >> +++ Makefile =A02012-05-27 13:54:13.928517659 -0400 >> @@ -7,7 +7,7 @@ >> >> =A0PORTNAME=3D =A0 =A0heimdal >> =A0PORTVERSION=3D 1.5.2 >> -PORTREVISION=3D =A0 =A0 =A0 =A02 >> +PORTREVISION=3D =A0 =A0 =A0 =A03 >> =A0CATEGORIES=3D =A0security ipv6 >> =A0MASTER_SITES=3D =A0 =A0 =A0 =A0http://www.h5l.org/dist/src/ \ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 http://ftp.pdc.kth.se/pub/heimdal/src/ \ >> @@ -39,7 +39,8 @@ >> =A0CONFIGURE_ARGS+=3D =A0 =A0 --with-libintl=3D${LOCALBASE} \ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 --with-readline=3D${DESTDIR}= /usr \ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 --enable-pthread-support \ >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 --with-hdbdir=3D/var/db/${PORT= NAME} >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 --with-hdbdir=3D/var/db/${PORT= NAME} \ >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 --sysconfdir=3D${LOCALBASE}/et= c >> =A0MAKE_ENV+=3D =A0 INSTALL_CATPAGES=3Dno > > You want to use PREFIX instead of LOCALBASE for sysconfdir. > > PREFIX is where the port will install into, LOCALBASE is where the > dependencies will be looked for. It's almost always the case that PREFIX > is the same as LOCALBASE but we should support them being different. > > Otherwise the patch looks sane to me. Awaiting Joerg's input before I > commit. Thanks again! Understood. Here's a new patch. Also, this particular behavior seems odd to me, and I think I will ping Heimdal's list about this. It seems to me that this configure flag shouldn't be needed, or at least all the daemons and utilities should look consistently in the same location if this flag is not set. --20cf307f323a0df45c04c112a92c Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h2r53thl0 LS0tIE1ha2VmaWxlLm9sZAkyMDEyLTA1LTI3IDEzOjUzOjAxLjEzMjUxNjk2NSAtMDQwMAorKysg TWFrZWZpbGUJMjAxMi0wNS0yNyAxMzo1NDoxMy45Mjg1MTc2NTkgLTA0MDAKQEAgLTcsNyArNyw3 IEBACiAKIFBPUlROQU1FPQloZWltZGFsCiBQT1JUVkVSU0lPTj0JMS41LjIKLVBPUlRSRVZJU0lP Tj0JMgorUE9SVFJFVklTSU9OPQkzCiBDQVRFR09SSUVTPQlzZWN1cml0eSBpcHY2CiBNQVNURVJf U0lURVM9CWh0dHA6Ly93d3cuaDVsLm9yZy9kaXN0L3NyYy8gXAogCQlodHRwOi8vZnRwLnBkYy5r dGguc2UvcHViL2hlaW1kYWwvc3JjLyBcCkBAIC0zOSw3ICszOSw4IEBACiBDT05GSUdVUkVfQVJH Uys9CS0td2l0aC1saWJpbnRsPSR7TE9DQUxCQVNFfSBcCiAJCQktLXdpdGgtcmVhZGxpbmU9JHtE RVNURElSfS91c3IgXAogCQkJLS1lbmFibGUtcHRocmVhZC1zdXBwb3J0IFwKLQkJCS0td2l0aC1o ZGJkaXI9L3Zhci9kYi8ke1BPUlROQU1FfQorCQkJLS13aXRoLWhkYmRpcj0vdmFyL2RiLyR7UE9S VE5BTUV9IFwKKwkJCS0tc3lzY29uZmRpcj0ke1BSRUZJWH0vZXRjCiBNQUtFX0VOVis9CUlOU1RB TExfQ0FUUEFHRVM9bm8KIAogSU5GTz0JCWhlaW1kYWwgaHg1MDkK --20cf307f323a0df45c04c112a92c--