Date: Wed, 18 Jul 2012 18:04:04 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Doug Barton <dougb@dougbarton.us> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org, Alex Kozlov <spam@rm-rf.kiev.ua>, ports-committers@freebsd.org, Niclas Zeising <zeising@freebsd.org> Subject: Re: svn commit: r301039 - head/archivers/zlib Message-ID: <CAMHz58Ra%2B8vfdefh5yqO=8YTbSVMcVh=PptDiPpav3xQMg2ObQ@mail.gmail.com> In-Reply-To: <50068063.1040701@dougbarton.us> References: <201207172057.q6HKvEJc094784@svn.freebsd.org> <5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org> <20120717230739.GA66332@ravenloft.kiev.ua> <5005F1E3.7080606@dougbarton.us> <20120717234412.GA69885@ravenloft.kiev.ua> <5005FDBD.5000407@dougbarton.us> <20120718001944.GA71608@ravenloft.kiev.ua> <500676B1.30403@dougbarton.us> <20120718091509.GA53570@FreeBSD.org> <50068063.1040701@dougbarton.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 18, 2012 at 5:22 PM, Doug Barton <dougb@dougbarton.us> wrote: > On 07/18/2012 02:15, Alexey Dokuchaev wrote: >> On Wed, Jul 18, 2012 at 01:41:21AM -0700, Doug Barton wrote: >>> On 07/17/2012 17:19, Alex Kozlov wrote: >>>> Those two lines above are not only list of distinfo files with absent >>>> EOL at the last line, but also an example of real parser which broken >>>> by such distinfo. >>> >>> So again, what I'm asking for are the *details* of what was broken, and >>> how. >>> >>> And FWIW, since that was my *first* question, you could have started off >>> with this answer instead of engaging in pointless theoretical discussion. >> >> Come on, guys, let's just fix the damn bug and be done with it. I totally >> understand how minor this issue is, yet how annoying in the same time (if we >> forget about very strict parsers). > > So you want us to do work for you, but you don't want to explain why? > > Meanwhile, since we don't know how the problem comes into being in the > first place, wouldn't it be better for you to share the problem you're > seeing so that we can help you find a more robust fix? > > You're taking sort of an absurd approach to what should have been a > really simple issue. > > Doug > > -- > If you're never wrong, you're not trying hard enough > > Hi Doug, AFAIK, if you download patch via patch file links [1], you'll get a patch file without newline character at the end of file. I guess most missing newline characters are caused by this problem. [1] e.g. http://www.freebsd.org/cgi/query-pr.cgi?pr=169349&getpatch=1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Ra%2B8vfdefh5yqO=8YTbSVMcVh=PptDiPpav3xQMg2ObQ>