From owner-freebsd-ports@FreeBSD.ORG Wed Oct 9 20:11:52 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0BA5E96C for ; Wed, 9 Oct 2013 20:11:52 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 97AE222A7 for ; Wed, 9 Oct 2013 20:11:51 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id hn3so98873wib.11 for ; Wed, 09 Oct 2013 13:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=O2jox0axBr5nPOw/AQe4RjxHZ5Y8vYqlr4Ubk2KOIT8=; b=CkxDXQpetl+KPJ2xPAc//k1Lkg2hjgYl/WzxQsbOQLLwniwZkFjdRvGF3xJ/nHL8kq VTDuI8J7zZUCMYTlx+WVWlDIt9985GHOfUfgldjn7OZW9LqL6jtw/6QPi0UKxBIrbZX9 F5f4cNw7T7CtOxnHEuaZrsrBLxCXC5DnxIKNHqfPgAMt4aMaUaQpQzK70iVBQICI5tOS mtpjSY04fNTsoQtz3DNXZz8uf46uCA8cVTdRv/+LuFkUHzkAGP+4TTcOquUBWa6zzosf s5KYXxACrYq3FPJHzSKYqpcP61ZFwbxfvSGZE+K04FD8gKGDpTcFRn4ZiPxZVLhOV1aR UWpQ== X-Received: by 10.180.189.49 with SMTP id gf17mr4230857wic.23.1381349509844; Wed, 09 Oct 2013 13:11:49 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id ft19sm18685602wic.5.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 09 Oct 2013 13:11:48 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 9 Oct 2013 22:11:45 +0200 From: Baptiste Daroussin To: Paul Schmehl Subject: Re: STAGE: explain man pages Message-ID: <20131009201145.GD95601@ithaqua.etoilebsd.net> References: <201310091944.r99JitwC014917@mech-cluster241.men.bris.ac.uk> <8C3BA28AE0814C587BE99BBB@Pauls-MacBook-Pro.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h" Content-Disposition: inline In-Reply-To: <8C3BA28AE0814C587BE99BBB@Pauls-MacBook-Pro.local> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: mexas@bris.ac.uk, freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Oct 2013 20:11:52 -0000 --veXX9dWIonWZEC6h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 09, 2013 at 03:00:33PM -0500, Paul Schmehl wrote: > --On October 9, 2013 8:44:55 PM +0100 Anton Shterenlikht =20 > wrote: >=20 > > I'm getting: > > > ># make stage > > =3D=3D=3D> Staging for urlview-0.9_7 > > =3D=3D=3D> Generating temporary packing list > > /bin/sh ./mkinstalldirs > > /usr/ports/textproc/urlview/work/stage/usr/local/bin install -s -o > > root -g wheel -m 555 urlview > > /usr/ports/textproc/urlview/work/stage/usr/local/bin/urlview install -o > > root -g wheel -m 444 urlview.man /usr/local/man/man1/urlview.1 This is buggy ^^ you probably want to patch the upstream Makefile to respect DESTDIR as it does for all other files it installs. What you want is to change line 321 of Makefile.in to add $(DESTDIR) yes wi= th parenthesis before $(mandir) as they already do in install-binPROGRAMS And upstream will also want that patch as that makes their installation sys= tem consistent > > -o root -g wheel -m 444 > > /usr/ports/textproc/urlview/work/urlview-0.9/sample.urlview > > /usr/ports/textproc/urlview/work/stage/usr/local/etc/urlview.conf.sample > > =3D=3D=3D=3D> Compressing man pages > ># > > > > Note that the man page is not installed on stage. > > > > The Makefile has: > > > > PLIST_FILES=3D bin/urlview \ > > etc/urlview.conf.sample \ > > urlview.1 > > > > The last file is the man page. > > > > What am I doing wrong? > > >=20 > You don't need to install or uninstall man pages. They're done=20 > automatically. >=20 > In the Makefile, use MANx=3D name of man pages > e.g MAN1=3D urlview.1 >=20 > Remove the manpage from the pkg-plist file. >=20 Wrong. Not with stage, see: https://wiki.freebsd.org/ports/StageDir and=20 http://blogs.freebsdish.org/portmgr/2013/10/03/staging/ the MANx macros never took care of installing the manpages btw. regards, Bapt --veXX9dWIonWZEC6h Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlJVuIEACgkQ8kTtMUmk6ExHggCeLwtor4SuuW/oBTAmncZT2kly SKsAniwm+0fTt6q33to04DRyWvxDJ79U =HW80 -----END PGP SIGNATURE----- --veXX9dWIonWZEC6h--