Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 May 2018 19:16:05 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r334220 - stable/11/sys/dev/cpuctl
Message-ID:  <201805251916.w4PJG5KG083202@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Fri May 25 19:16:05 2018
New Revision: 334220
URL: https://svnweb.freebsd.org/changeset/base/334220

Log:
  MFC r334050, r334051:
  Flush caches before initiating a microcode update on Intel CPUs.
  
  Approved by:	re (gjb, kib)

Modified:
  stable/11/sys/dev/cpuctl/cpuctl.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/cpuctl/cpuctl.c
==============================================================================
--- stable/11/sys/dev/cpuctl/cpuctl.c	Fri May 25 19:12:30 2018	(r334219)
+++ stable/11/sys/dev/cpuctl/cpuctl.c	Fri May 25 19:16:05 2018	(r334220)
@@ -365,8 +365,10 @@ update_intel(int cpu, cpuctl_update_args_t *args, stru
 	rdmsr_safe(MSR_BIOS_SIGN, &rev0); /* Get current microcode revision. */
 
 	/*
-	 * Perform update.
+	 * Perform update.  Flush caches first to work around seemingly
+	 * undocumented errata applying to some Broadwell CPUs.
 	 */
+	wbinvd();
 	wrmsr_safe(MSR_BIOS_UPDT_TRIG, (uintptr_t)(ptr));
 	wrmsr_safe(MSR_BIOS_SIGN, 0);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805251916.w4PJG5KG083202>